[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: ruby-kgio, ruby-raidrops



Christian Hofstädtler <zeha@debian.org> wrote:
> ruby-kgio doesn’t build for me:
> 
> Finished tests in 78.967241s, 4.6095 tests/s, 113746.5844 assertions/s.
> 
>   1) Failure:
> test_trywritev_return_wait_writable(TesTcpServerReadClientWrite) [/«PKGBUILDDIR»/test/lib_read_write.rb:295]:
> Failed assertion, no message given.
> 
> 364 tests, 8982254 assertions, 1 failures, 0 errors, 0 skips
> 
> ruby -v: ruby 2.0.0p457 (2014-03-03) [x86_64-linux-gnu]

Hi Christian, can you try the following?  I think this is a bug in
the test.

--- a/test/lib_read_write.rb
+++ b/test/lib_read_write.rb
@@ -292,7 +292,8 @@ module LibReadWriteTest
     assert_equal :wait_writable, tmp.pop
     assert tmp.size > 0
     penultimate = tmp.pop
-    assert(penultimate == "I" || penultimate == nil)
+    assert(penultimate == ["I"] || penultimate == nil,
+           "penultimate is #{penultimate.inspect}")
     assert tmp.size > 0
     tmp.each { |count| assert_equal nil, count }
   end

-- 
Eric Wong


Reply to: