Hi David, On Sun, Sep 07, 2014 at 11:16:59PM +0200, David Suárez wrote: > El Lunes, 16 de junio de 2014 21:24:13 David Suárez escribió: > > Hi, > > > > Any chance to get the package reviewed and uploaded ? > > > > ruby-aws-sdk (1.43.2-1) unstable; urgency=medium > > > > * Initial release (Closes: #751676) > > > > It builds fine on a sid chroot. > > > > Thanks in advance, > > David > Any chance to get thing uploaded ? :) Here is a quick review: I think that it would better to place the files endpoints.json and ca-bundle.crt under /usr/share/ruby-aws-sdk. This requires to adapt use-correct-path-for-bundled-certificate and to add a patch for lib/aws/core/endpoints.rb Also, the pristine-tar branch contains a tar ball, but with the wrong name (should be ruby-aws-sdk_1.43.2.orig.tar.gz, not aws-sdk_1.43.2.orig.tar.gz) There is a newer upstream version (1.52.0 instead of 1.43.2). Do you want to update your packaging for this new version? Otherwise, looks fine to me. Cheers, Cédric
Attachment:
signature.asc
Description: Digital signature