[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: ruby-timeline-setter



On Saturday 16 August 2014 11:08 AM, ബാലശങ്കർ സി wrote:
> I have some doubts. Inline :-
> 
>> 1. Please install documentation
>> see debian/ruby-timeline-setter.docs file
> There is a doc folder, and documentation folder in the repo. Should I add both of them? gem2deb automatically detected doc only.

Both are different, so install both.

>> 2. in debian/control:
>> uncomment the vcs fields
> 
> Should the Vcs-git be changed from anonscm.debian.org to git.debian.org? Because, I created the repo in git.debian.org, right?
> Or, is anonscm.debian.org same as git.debian.org?

They are the same.

>> 3. Did you test if the package is working as expected after
>> installation? Make sure all required dependencies are satisfied.
>>
>> 4. Try to run the tests
> 
> I have added 
>  $: << 'lib' << '.'
>   Dir['../{spec,test}/**/*.rb'].each { |f| require f }
> to debian/ruby-tests.rb file. Is that enough?

Build the package and see if tests are run. You may use ruby-tests.rake
since it is using rspec. See wiki for the steps.

>> Also please track all changes you made after running gem2deb in git.
> 
> So, shall I delete the current repo and create a new one? To track changes from scratch?
> 

yes.

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: