[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#703188: Re: Bug#703188: Offer to sponsor ruby-pygments.rb



On Friday 28 February 2014 14:59:55 Axel Wagner wrote:
> I think the open issues should be fixed now. Could you please have a
> look and upload if appropriate?

I had a quick look. There are still some issues:

control:
- you should put yourself in uploader
- update standards version to 3.9.5


copyright:
- The copyright clause for vendor/pygments-main/*. Specifying "The pygment 
team" as copyright owner is dubious, this is not people and not a company. 
vendor/pygments-main/AUTHORS contains more information. You should specify the 
3 main people and refer to this file in a Comment line.
- The MIT license you mention should have "Expat" short-name. See
   https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-specification "There are many versions of the MIT license. Please use Expat 
instead, when it matches."
- you can add yourself in debian/* clause

May be add a comment in copyright file mentioning that vendors/pygments-main 
and vendors/simplejson are not used (disabled by patch 0002-Don-t-set-
PYGMENTS_PATH-and-remove-sys.path-appends)

Please add headers to debian patches. You can use 'cme edit dpkg' to edit 
these headers. Ideally, you should explain the rationale of each patch in 
their headers.



All the best



-- 
 https://github.com/dod38fr/   -o- http://search.cpan.org/~ddumont/
http://ddumont.wordpress.com/  -o-   irc: dod at irc.debian.org


Reply to: