[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: ruby-hiera



Hi Jonas,

On Thu, Nov 21, 2013 at 11:10:56PM +0100, Jonas Genannt wrote:
> Hello,

> since 1.2.1-1 was not uploaded, I have packaged 1.3.0. Could any dd please have a look and
> upload it into unstable?


The package looks fine: it builds in a clean chroot and tests pass.
I have just a couple of pedantic remarks/questions about details:
- there are some typos in the description (should be "hierarchical" in the short
  description, "therefore" and "used to query" in the long description).
- shouldn't the package recommend or at least suggest ruby-hiera-puppet?
- the changelog entry contains items corresponding to several steps
  about the same change (for example iterations on the watch file). I
  think some should be removed/merged.

Cheers,

Cédric

Attachment: signature.asc
Description: Digital signature


Reply to: