[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: ruby-shadow: new upstream version (fix FTBFS with ruby2.0 #720229)



Hi Cédric,

El Lunes, 21 de octubre de 2013 23:52:13 Cédric Boutillier escribió:
> On Mon, Oct 21, 2013 at 09:55:42PM +0200, David Suárez wrote:
> > Uploaded. Just remove it, (it generates more problems than
> > advantages).
> 
> After building it, I got from lintian the following warnings:
> W: ruby-shadow: hardening-no-relro
> usr/lib/ruby/vendor_ruby/1.9.1/x86_64-linux/shadow.so W: ruby-shadow:
> hardening-no-relro
> usr/lib/x86_64-linux-gnu/ruby/vendor_ruby/2.0.0/shadow.so
> 
> It seems that the current extconf.rb overwrites the CFLAGS/LDFLAGS. You
> should patch it with something like the following to make it append
> options to the flags, not overwriting them:
> 
> 
> --- a/extconf.rb
> +++ b/extconf.rb
> @@ -6,7 +6,7 @@
> 
>  require 'mkmf'
> 
> -$CFLAGS = case RUBY_VERSION
> +$CFLAGS += case RUBY_VERSION
>            when /^1\.9/; '-DRUBY19'
>            when /^2\./; '-DRUBY19'
>            else; ''
> @@ -15,7 +15,7 @@
>  #$LDFLAGS = "-lshadow"
> 
>  if( ! (ok = have_library("shadow","getspent")) )
> -  $LDFLAGS = ""
> +  #$LDFLAGS = ""
>    ok = have_func("getspent")
>  end
> 
> Could you please also remove the capital letter from the beginning of
> the short description and maybe extend a bit the long description?

Updated, thanks for the help.

  David

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: