On Tue, 2013-04-23 at 13:41 +0200, Cédric Boutillier wrote: > There is just one last thing: in contradiction with what I've said > before, ruby-dbf should Depend on, and not simply recommend > ruby-fastercsv (at least as long as the package supports ruby1.8 for > which CSV.const_defined? :Reader gives true). This is partially why > tests fail with ruby-georuby. Done. > Except that, I believe the package is ready. Are you already a member of > the Ruby Extras team on alioth.debian.org? If no, please ask to join the > team on alioth. Then can you import ruby-dbf to the team repository? > Instructions are available on > http://wiki.debian.org/Teams/Ruby/Packaging. I have requested to join, my username is cbaines-guest. > > The only possible issue I know of with the dbf package, is that the > > related tests for the ruby-georuby [1] package fail, when run in a > > chroot environment. > > The tests are failing because ruby-dbf cannot work with ruby1.8 without > fastercsv. When you patched out the use of rubygems, you forgot > spec/spec_helper.rb. > > Also, I would have removed the begin/end block rescuing a possible load > error when there was a rubygems: like: > > --- a/lib/geo_ruby/shp4r/dbf.rb > +++ b/lib/geo_ruby/shp4r/dbf.rb > @@ -1,12 +1,6 @@ > # Uses the dbf lib, Copyright 2006 Keith Morrison (http://infused.org) > # Modified to work as external gem now > -require 'rubygems' > -begin > - require 'dbf' > -rescue LoadError > - puts "You've loaded GeoRuby SHP Support." > - puts "Please install the gem 'dbf' to use it. `gem install dbf`" > -end > +require 'dbf' > > (same for lib/geo_ruby/geojson.rb) > > Only three tests are run because the regexp in debian/ruby-tests.rake is > too strict. Should be > spec.pattern = './spec/**/*_spec.rb' > to run the specs in subdirectories also. However, it seems that one of > the tests hangs. Hmm, it eats all my ram... I will look in to this further.
Attachment:
signature.asc
Description: This is a digitally signed message part