On Sun, Aug 18, 2013 at 01:15:05PM -0400, Sam Kottler wrote: > Cédric, > Just wanted to follow up - can you take a look at the updated package? Here is a long due review: First, could you consider packaging version 0.1.3? It contains the missing license. Could you please also consider a git repository to maintain your package? This would ease the review process, as we could identify easily the changes you made to the package. Consider joining the Ruby team on alioth.debian.org and use our team repos if it is convenient for you, especially since you listed the team as the maintainer. (it is really easier for us than mentors.debian.org). I see on the discussion below that you're in fact already in the team and have issues about connection to alioth. You really need a public SSH key. Access with password is disabled. In debian/changelog, the paragraph about the copyright license of files under debian/ is missing. Please add your name there and preferably choose the same license as upstream. In debian/changelog, merge the two entries and set the distribution from UNRELEASED to unstable. In debian/patch: add a DEP-3 header to remove_rubygem_requires.diff. See dep.debian.net/deps/dep3/ for details. The Standards-Version is now 3.9.5. If you import the package in our team repos, you'll need to uncomment the Vcs-* fields in that file too. The tests still depends on the missing ruby-dbi-dbrc. Cheers, Cédric > -Sam > On Sat, Aug 3, 2013 at 12:56 PM, Sam Kottler <sam@kottlerdevelopment.com>wrote: > >> [...] > >> > >> debian/copyright: > >> - you indicate Artistic 2.0 for the license, but the text in this > >> paragraph refers to GPL-2+. > > > > - unless you have a strong opinion about the license you use, > >> use the same license as upstream as it makes easier distribution of > >> your work. > >> > > > > I've changed the debian/* copyright to Artistic 2.0. > > > > > >> - the only place where the license is indicated is the gemspec > >> metadata. Maybe ask upstream to include the text of the license in > >> the source > >> > > > > I submitted an issue - https://github.com/domcleal/rkerberos/issues/2 > > > > > >> > >> debian/control: > >> - there is a commented line below Depends: field which can be removed. > >> > > > > Removed. > > > > > >> - there is no mention of Ruby in the long description. > >> > > > > Added. > > > > > >> - Vcs-* fields are commented. If you consider maintaining this package > >> under Ruby team's umbrella, uncomment those fields, and ask to join > >> the team on Alioth and import the package to the team repository > >> > > > > Despite already being in the team on alioth I can't SSH into > > git.debian.org or clone with my username. It's just denying my key and is > > solely trying pubkey authentication, there's no prompt for my password. Is > > there something else I need to do to get access? > > > > > >> > >> debian/ruby-rkerberos.docs > >> - remove the first line and uncomment the second to include the README > >> in usr/share/doc/ruby-rkerkeros > >> > > > > Done. > > > > > >> > >> tests: > >> - tests are run but fail: > >> /usr/lib/ruby/vendor_ruby/1.8/rubygems/dependency.rb:247:in > >> `to_specs': Could not find test-unit (>= 0) amongst [] (Gem::LoadError) > >> A build-dependency on ruby-test-unit is missing. You'll need to > >> package ruby-dbi-dbrc (http://rubygems.org/gems/dbi-dbrc) if you want > >> to run all the tests (test_kadm5.rb needs it). > >> > > > > I've submitted an ITP for ruby-dbi-dbrc and ruby-sys-admin and submitted > > builds to mentors.debian.ent for both. I'll send a RFS here right after I > > hit send on this email. > > > > > >> - all tests have a "require 'rubygems'" and "gem 'test-unit'" . You > >> should patch them out > >> with quilt (and add a DEP-3 header to the patch > >> http://dep.debian.net/deps/dep3/) > >> > > > > Done. > > > > > >> - do not ignore test failures in debian/rules > >> > > > > The test failures are still ignored because they can't pass until > > ruby-dbi-dbrc is available. > > > > > >> > >> lintian gives some messages: > >> P: ruby-rkerberos source: debian-control-has-unusual-field-spacing line 5 > >> > > > > Fixed. > > > > > >> I: ruby-rkerberos: hardening-no-fortify-functions > >> usr/lib/ruby/vendor_ruby/1.8/x86_64-linux/rkerberos.so > >> I: ruby-rkerberos: hardening-no-fortify-functions > >> usr/lib/ruby/vendor_ruby/1.9.1/x86_64-linux/rkerberos.so > > > > I: ruby-rkerberos: extended-description-is-probably-too-short > >> > > > > I've added a bit more to the description about the gem's origins. > > > > > >> > >> > >> Cheers, > >> > > > > Thanks so much for the review! I've updated the package and uploaded it to > > mentors.debian.net again. > > > > > >> > >> Cédric > >> > > > >
Attachment:
signature.asc
Description: Digital signature