[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: ruby-stamp 0.5.0



Hello Cedric,

Thank you for your suggestions!

On Mon, Jul 29, 2013 at 00:01:55 +0200, Cédric Boutillier wrote:
>   This maybe related to rubygems-integration bug #710814. Since you just
>   need to call cucumber to run the tests, you may try instead of
>   ruby-tests.rake a one-line ruby-tests.rb with:
>   ---------8<--------
>   exec(ENV['RUBY_TEST_BIN'], "/usr/bin/cucumber")
>   --------->8--------
>   that would allow you to get rid of rake as a build-dep and solve the
>   rubygems dilemma in your P.S.

Done, thank you!

> - I noticed you have included Gemfile.lock in the .gitignore file. The
>   .gitignore file is a file included in the upstream tarball. It is a
>   bad idea to modify it since it will create a conflict when you import
>   a new upstream version. Since Gemfile.lock is *not* included in the
>   upstream tarball, you can instead just make sure that it is cleaned
>   adter the build by adding it to debian/clean. However, I think that
>   this problem is solved automatically if you adopt my proposition for
>   the first point, since this file was not created if ruby-tests.rake is
>   replaced by ruby-tests.rb.

I reverted the commit removing it from .gitignore.

> - It is considered good practice to put the Debian packaging under the
>   same license as the upstream project. Unless you have a strong opinion
>   on that, I'd suggest you switch the license of debian/ to Expat.

Relicensed to Expat, so.

Regarding the only patch in debian/patches - should I have it remove
Rakefile entirely, or does it not matter? And I suppose "require 'rake'"
should not be added like it is now?

Thank you again!

-- 
Daniel Martí - mvdan@mvdan.cc - GPG 0x4348041C

Attachment: pgpZKL6LVLYJZ.pgp
Description: PGP signature


Reply to: