Hi Christopher, On Sun, Apr 21, 2013 at 10:25:59PM +0100, Christopher Baines wrote: > On Wed, 2013-03-13 at 21:57 +0100, Cédric Boutillier wrote: > > On Wed, Mar 13, 2013 at 05:36:50PM +0000, Christopher Baines wrote: > > > I have now managed to setup cowbuilder and attempt to reproduce the > > > failing you mention here [2], I have tried building the package (from > > > the git repo, reset to before I apply the relevant patch), in testing > > > and sid for amd64 and i386, but I have not seen anything in the output > > > that looks to me like a failing test. What cowbuilder setup did you > > > use to produce the test failure? > > > > That is because the tests are not run: when building with > > git-buildpackage, I have the following message: > > > > /usr/bin/ruby1.8 -I/usr/lib/ruby/vendor_ruby /usr/lib/ruby/vendor_ruby/gem2deb/test_runner.rb > > No examples matching ./spec/*_spec.rb could be found > > /usr/bin/ruby1.9.1 -I/usr/lib/ruby/vendor_ruby /usr/lib/ruby/vendor_ruby/gem2deb/test_runner.rb > > No examples matching ./spec/*_spec.rb could be found > > > > In debian/ruby-tests.rake, the regular expression for the tests does not > > match any file. Changing it to './spec/**/*_spec.rb' make the tests run, > > but fail (two of them) with Ruby1.9 without the encoding fixing patch. > > With the three patches, they all pass. > This is fixed now on github. > https://github.com/cbaines/ruby-dbf There is just one last thing: in contradiction with what I've said before, ruby-dbf should Depend on, and not simply recommend ruby-fastercsv (at least as long as the package supports ruby1.8 for which CSV.const_defined? :Reader gives true). This is partially why tests fail with ruby-georuby. Except that, I believe the package is ready. Are you already a member of the Ruby Extras team on alioth.debian.org? If no, please ask to join the team on alioth. Then can you import ruby-dbf to the team repository? Instructions are available on http://wiki.debian.org/Teams/Ruby/Packaging. > The only possible issue I know of with the dbf package, is that the > related tests for the ruby-georuby [1] package fail, when run in a > chroot environment. The tests are failing because ruby-dbf cannot work with ruby1.8 without fastercsv. When you patched out the use of rubygems, you forgot spec/spec_helper.rb. Also, I would have removed the begin/end block rescuing a possible load error when there was a rubygems: like: --- a/lib/geo_ruby/shp4r/dbf.rb +++ b/lib/geo_ruby/shp4r/dbf.rb @@ -1,12 +1,6 @@ # Uses the dbf lib, Copyright 2006 Keith Morrison (http://infused.org) # Modified to work as external gem now -require 'rubygems' -begin - require 'dbf' -rescue LoadError - puts "You've loaded GeoRuby SHP Support." - puts "Please install the gem 'dbf' to use it. `gem install dbf`" -end +require 'dbf' (same for lib/geo_ruby/geojson.rb) Only three tests are run because the regexp in debian/ruby-tests.rake is too strict. Should be spec.pattern = './spec/**/*_spec.rb' to run the specs in subdirectories also. However, it seems that one of the tests hangs. Cheers, Cédric
Attachment:
signature.asc
Description: Digital signature