[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: sup-mail 0.12-1+git20120407.aaa852f-1



Hi!

On Fri, May 25, 2012 at 10:13 PM, Per Andersson <avtobiff@gmail.com> wrote:
> Hi!
>
> On Thu, May 24, 2012 at 10:43 AM, Per Andersson <avtobiff@gmail.com> wrote:
>> Hi!
>>
>> On Wed, May 23, 2012 at 1:35 PM, Cédric Boutillier
>> <cedric.boutillier@gmail.com> wrote:
>>>
>>> - Trying to expand a signature in the thread view mode yields a crash
>>>  with the following trace:
>>>
>>>  --- NoMethodError from thread: main
>>>  private method `chomp' called for nil:NilClass
>>>  /usr/lib/ruby/vendor_ruby/sup/modes/thread-view-mode.rb:849:in `maybe_wrap_text'
>>>  /usr/lib/ruby/vendor_ruby/sup/modes/thread-view-mode.rb:849:in `map'
>>>  /usr/lib/ruby/vendor_ruby/sup/modes/thread-view-mode.rb:849:in `maybe_wrap_text'
>>>  /usr/lib/ruby/vendor_ruby/sup/modes/thread-view-mode.rb:876:in `chunk_to_lines'
>>>  /usr/lib/ruby/vendor_ruby/sup/modes/thread-view-mode.rb:752:in `regen_text'
>>>  /usr/lib/ruby/vendor_ruby/sup/modes/thread-view-mode.rb:741:in `each'
>>>  /usr/lib/ruby/vendor_ruby/sup/modes/thread-view-mode.rb:741:in `regen_text'
>>>  /usr/lib/ruby/vendor_ruby/sup/thread.rb:81:in `each'
>>>  /usr/lib/ruby/vendor_ruby/sup/thread.rb:174:in `each_with_stuff'
>>>  /usr/lib/ruby/vendor_ruby/sup/thread.rb:78:in `each'
>>>  /usr/lib/ruby/vendor_ruby/sup/thread.rb:75:in `each'
>>>  /usr/lib/ruby/vendor_ruby/sup/modes/thread-view-mode.rb:710:in `regen_text'
>>>  /usr/lib/ruby/vendor_ruby/sup/modes/thread-view-mode.rb:696:in `update'
>>>  /usr/lib/ruby/vendor_ruby/sup/modes/thread-view-mode.rb:339:in `activate_chunk'
>>>  /usr/lib/ruby/vendor_ruby/sup/mode.rb:59:in `send'
>>>  /usr/lib/ruby/vendor_ruby/sup/mode.rb:59:in `handle_input'
>>>  /usr/lib/ruby/vendor_ruby/sup/buffer.rb:278:in `handle_input'
>>>  /usr/bin/sup-mail:271
>
> Yeah I also get this. I'll dig into it.

I managed to fix this. See [0] for the trivial fix. Please review and
try it out.

[0] http://anonscm.debian.org/gitweb/?p=pkg-ruby-extras/sup-mail.git;a=commit;h=39c5d26a8e918c498f178b98dd5fff1c47335c3b


Best,
Per


Reply to: