Re: RFS: sup-mail 0.12.1+git20120407.aaa852f-1
Hi!
On Sun, May 13, 2012 at 11:49 PM, Cédric Boutillier
<cedric.boutillier@gmail.com> wrote:
> Hi Per,
>
>> The following packages are ready to be uploaded (I also verified the
>> points listed on
>> http://wiki.debian.org/Teams/Ruby/RubyExtras/RequestingSponsorship).
>
>> Could you please sponsor them?
>
>> sup-mail 0.12.1+git20120407.aaa852f-1
>
> Thank you for taking care of sup-mail. I have successfully built the
> package. Lintian reports a few errors/warnings:
>
> I: sup-mail source: debian-watch-file-is-missing
I tried to create a watch-file for gitorious but the git tag links on
the site does
not have the tag name in the href, just a sha1. AFAIK this is a show stopper
for uscan which scans hrefs to run the version regex against.
Should I create a lintian override for this?
> I: sup-mail: hyphen-used-as-minus-sign usr/share/man/man1/sup-recover-sources.1.gz:20
> I: sup-mail: hyphen-used-as-minus-sign usr/share/man/man1/sup-recover-sources.1.gz:25
Fixed.
> In the copyright file, the short name of a license should be just one
> word: maybe use "Ruby" instead of "Ruby License".
Fixed.
> I see you ignore the tests results. Have you investigated why they are
> failing? Maybe at least some should be included.
This is the error message when building and failing on test errors:
(...)
-I/usr/lib/ruby/vendor_ruby /usr/lib/ruby/vendor_ruby/gem2deb/test_runner.rb
ERROR: Test "1.8" failed. Exiting.
dh_auto_install: dh_ruby --install
/home/avtobiff/debian/packages/pkg-ruby-extras/sup-mail/debian/sup-mail
returned exit code 1
make: *** [binary] Error 1
dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2
debuild: fatal error at line 1350:
dpkg-buildpackage -rfakeroot -D -us -uc failed
IIUC this is some gem2deb built in test (not the tests that are
shipped with sup)?
I have tried getting to the source of this but I am not fluent in ruby
so I have not
yet found the reason for this failure.
I would be happy to just get some pointers at where to look for the
test that fails.
> It installs ok, but when I tried to launch it, it crashed immediately
> with the following error:
>
> --- NoMethodError from thread: main
> undefined method `set_engine_info' for GPGME:Module
> /usr/lib/ruby/vendor_ruby/sup/crypto.rb:68:in `initialize'
> /usr/lib/ruby/vendor_ruby/sup/util.rb:576:in `new'
> /usr/lib/ruby/vendor_ruby/sup/util.rb:576:in `init'
> /usr/lib/ruby/vendor_ruby/sup.rb:169:in `start'
> /usr/lib/ruby/vendor_ruby/sup.rb:169:in `each'
> /usr/lib/ruby/vendor_ruby/sup.rb:169:in `start'
> /usr/bin/sup-mail:164
>
> It is because it is not made to work with the version 2.0 of ruby-gpgme.
> Fortunately, there are some patches on gitorious solving this issue you may want to import:
>
> http://gitorious.org/sup/mainline/merge_requests/12
I'll have a look at this.
> I have not tried them, though. Maybe there is more nice stuff to import
> from there.
I'll see what I can find.
Thanks for your eye for details!
--
Per
> Best wishes,
>
> Cédric
Reply to: