Re: ruby-mysql2 package is prepared

2012/11/1 Michael Franzl <michaelfranzl@gmx.at>

On 10/29/2012 03:21 PM, Praveen A wrote:

Your next step would to have someone review your package. You can
upload your package to mentors.debian.net and pass link to your dsc
file as a reply.

http://mentors.debian.net/debian/pool/main/r/ruby-mysql2/ruby-mysql2_0.3.11-1.dsc

As the team uses git repo for its packaging work, you may put your
packaging in a git repo instead of uploading to mentors and pass the
git repo url here.

https://github.com/michaelfranzl/ruby-mysql2

The package needs review and a sponsor. Awaiting further instructions.

Thanks! I had a look at your package and here are some comments.

1. Make sure your run the tests under spec directory. You may take ruby-orm-adapter as an example, see

http://anonscm.debian.org/gitweb/?p=pkg-ruby-extras/ruby-orm-adapter.git;a=blob;f=debian/ruby-tests.rake;h=89a753d9aca2995f6f395a1ae7cfd82b28a5d144;hb=HEAD

If tests fail because of any missing files make sure those libraries needed to run the tests are installed and add them to build-depends.

2. You may want to add more to the extended description. It is shown to users who want to learn more about the package, for example when you run apt-cache show ruby-mysql2. Add some info about what this package does and why this is better than ruby-mysql etc.

3. Upstream provide a changelog file, consider installing it via an override of rules file. Again see ruby-orm-adapter as an example http://anonscm.debian.org/gitweb/?p=pkg-ruby-extras/ruby-orm-adapter.git;a=blob;f=debian/rules;h=61a35956d1fb9d48bc5d5ae99038737b78be22d5;hb=HEAD

4. In changelog file, target "unstable" release instead of "UNRELEASED"

5. Install examples using the templete given

6. Since upstream and your packaging files have the same license, you need to specify the full text of the license only once. See http://anonscm.debian.org/gitweb/?p=pkg-ruby-extras/ruby-orm-adapter.git;a=blob;f=debian/copyright;h=335cca71dc4319394dc4b095f6fb9db94aa676cc;hb=HEAD

7. Add some descriptions to your patch, it currently has a generated template

8. I suggest you re-import your package with --pristine-tar option to git-import-dsc command. Also you need to remove the tag debian/0.3.11-1 (your sponsor will add this tag when it is ready for upload).

9. I suggest you request membership at https://alioth.debian.org/projects/pkg-ruby-extras/ as all team packages are maintained there.

--
പ്രവീണ്‍ അരിമ്പ്രത്തൊടിയില്‍
You have to keep reminding your government that you don't get your rights from them; you give them permission to rule, only so long as they follow the rules: laws and constitution.