[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: devise_invitable



On Tue, Oct 23, 2012 at 09:04:32PM +0200, tornow@riseup.net wrote:
> Hi all!
> Sorry, i forgot to add the link (i rather didn't know).
> https://mentors.debian.net/package/ruby-devise-invitable
> greetings; M.Tornow

Some more comments in complement to Serafeim's:

- debian/copyright is not conform to copyright-format/1.0:
it should be closer to:

-----------8<--------------------

Upstream-Name: devise_invitable 
Source: https://github.com/scambra/devise_invitable 

Files: *
Copyright: 2009 Sergio Cambra <?email?>
License: Expat


Files: debian/*
Copyright: 2012 Your Name <your email>
License: Expat

License: Expat
 Permission is hereby granted, free of charge, to any person
 obtaining a copy of this software and associated documentation
 files (the "Software"), to deal in the Software without
 restriction, including without limitation the rights to use,
 copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the
 Software is furnished to do so, subject to the following
 conditions:
 .
 The above copyright notice and this permission notice shall be
 included in all copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
 EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
 OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
 NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
 HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
 WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
 OTHER DEALINGS IN THE SOFTWARE.
--------->8-------------
Please mind the spaces and the dots in the description of the license.
One copyright line per Files paragraph. See 
http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/

This line is mysterious. Where did it come from?
Copyright: (c) 2009-2011 Jeremy Ashkenas, DocumentCloud

- I am pretty sure it misses dependencies: trying to load
  devise_invitable.rb in irb, it complains about missing "devise".
  Rubygems lists as dependencies: actionmailer, devise, railties, and I
  believe that devise is not packaged yet.
  Please check that your package has the correct dependencies. This is
  not as easy as if there were tests, but collecting the "require 'foo'"
  statements from the lib will help.

- I have no experience in packaging rail apps, but probably the files in
  app/ and config/ are needed. gem2deb by default does not include them
  in the binary packages, so you need to decide if and where to put
  them.

- about debian/ruby-devise-invitable.docs, just remove comments to
  leave the line README.rdoc, without the leading #, so that this file
  is included in /usr/share/doc/ruby-devise-invitable.docs





Attachment: signature.asc
Description: Digital signature


Reply to: