[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: ruby-locale, ruby-gettext, unicorn



On 9/26/12, Cédric Boutillier <cedric.boutillier@gmail.com> wrote:
> You fixed all these issue, except the last one. You answered that
> you use gbp-pq to manage the patch queue. I am not familiar with gbp-pq
> workflow. Is it related to #599146?

It seems to be so.

> Thank you for expanding the description of ruby-locale. I see that it
> has been adapted from the homepage of ruby-locale
>   http://www.yotabanana.com/hiki/ruby-locale.html
> However I find it a little bit obscure. May I suggest that you contact
> debian-l10n-english@l.d.o and ask them to help with a better
> formulation, as they did with ruby-gettext?

Done.

> Another remark about ruby-gettext: I am not sure that you need to keep
> the alternatives ruby-locale | liblocale-ruby1.8, ruby-locale |
> liblocale-ruby1.9.1
> in Build-Depends field, since the liblocal-ruby* are now obsolete
> packages. Maybe just replace it by ruby-locale. Also rake is not needed
> any more since you changed the way tests are run.

Done.

> lintian complains about unescaped minus signs in the unicorn* manpages.
> Maybe you can patch them and send the fix to upstream? Other than that,
> I think it is ok.

Done.


Reply to: