[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: ruby-tokyocabinet



On Sat, Apr 09, 2011 at 02:51:19PM +0200, Lucas Nussbaum wrote:
> On 09/04/11 at 14:33 +0200, Laurent Arnoud wrote:
> > Hello,
> > 
> > I've updated the tokyocabinet-ruby package using now gem2deb and other minor
> > update.
> > 
> > The packaging is now here:
> > Browser: http://git.debian.org/?p=pkg-ruby-extras/tokyocabinet-ruby.git
> > Git: git://git.debian.org/pkg-ruby-extras/tokyocabinet-ruby.git
> 
> Hi,
> 
> Why tokyocabinet-ruby and not ruby-tokyocabinet?
>

Just for keep the old, the qa page will be broken ?
http://packages.qa.debian.org/t/tokyocabinet-ruby.html

> > I added myself as uploader for lintian, tell me if its not a good practice.
> 
> It is.

Oki i will remove myself

> 
> Review:
> ruby-tokyocabinet-doc.rdoc: what's that file for?
> 
> Other fixes (committed to git):
> --- a/debian/control
> +++ b/debian/control
> @@ -1,5 +1,5 @@
>  Source: tokyocabinet-ruby
> -Section: libs
> +Section: ruby
>  Priority: extra
>  Maintainer: Debian Ruby Extras Maintainers <pkg-ruby-extras-maintainers@lists.alioth.debia
>  Uploaders: Paul van Tilburg <paulvt@debian.org>, Marc Dequènes (Duck) <Duck@DuckCorp.org>,
> @@ -12,12 +12,11 @@ Vcs-Browser: http://git.debian.org/?p=pkg-ruby-extras/tokyocabinet-ruby
>  XS-Ruby-Versions: all
>  
>  Package: ruby-tokyocabinet
> -Section: ruby
>  Architecture: any
>  XB-Ruby-Versions: ${ruby:Versions}
>  Depends: ${shlibs:Depends}, ${misc:Depends}, ruby1.8 | ruby-interpreter
>  Suggests: libtokyocabinet-ruby-doc
> -Description: Ruby Binding of Tokyo Cabinet Database (ruby 1.8)
> +Description: Ruby Binding of Tokyo Cabinet Database
>   Tokyo Cabinet is an efficient database library like GDBM and NDBM.
>   It features hash database and B+ tree database and is developed as the
>   successor of QDBM, for the purpose of the following three points: higher
> 
> #	renamed:    ruby-tokyocabinet-doc.exemples -> ruby-tokyocabinet-doc.examples
> 
> Please address the source package name change, and then I can upload.

I will do, thanks Lucas for the review.

-- 
Laurent


Reply to: