Re: RFS: ruby-lapack

[Lucas Nussbaum <lucas@lucas-nussbaum.net>]

On 07/04/11 at 15:38 +0900, Youhei SASAKI wrote:
> Hi,
> 
> At 6 Apr 2011 14:09:48 +0200,
> "Lucas Nussbaum" <lucas@lucas-nussbaum.net> wrote:
> >
> > I've done a quick review. I would appreciate if someone else would do
> > another one.
> >
> > Small fix (committed):
> > -       dh $@ --buildsystem=ruby --with ruby --with quilt
> > +       dh $@ --buildsystem=ruby --with ruby
> > (--with quilt is not needed anymore)
> 
> How do you treat .pc? Should I use patch-queue manner on git-buildpackage?

I don't commit it to the git repo. But we could decide to do the
opposite... It's mainly a matter of taste.

Anyway, debhelper now detects when quilt is used, that's why --with
quilt is not needed.

> > Other question:
> > would it make sense to run the sample script at the end of the build, to
> > see if everything works fine? I'm a bit disturbed by the lack of test
> > suite.
> 
> Currently, I'm frequently using this library on amd64 and i386.
> This library works fine. However, I think your comment is reasonable.

Well, the point is to ensure that we will know if the library breaks in
some months. :)

- Lucas