Hi Youhei,
Thanks for looking at this!
Youhei SASAKI escreveu isso aí:
> Hi,
>
> I fix ruby-ole's FTBFS and commit whole changes to pkg-ruby-extra's Git repo.
>
> Please check and upload it.
> Vcs-Git: git://git.debian.org/pkg-ruby-extras/ruby-ole.git
> Vcs-Browser: http://git.debian.org/?p=pkg-ruby-extras/ruby-ole.git;a=summary
Your fix broke running the tests from within the source dir with `rake
test`:
terceiro@morere:~/src/debian/pkg-ruby-extras/ruby-ole (master)$ git checkout master^
Note: checking out 'master^'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:
git checkout -b new_branch_name
HEAD is now at f84a0b5... Merge in the previous incarnation packaging details
terceiro@morere:~/src/debian/pkg-ruby-extras/ruby-ole ((debian/1.2.11.1-4))$ rake test
(in /home/terceiro/src/debian/pkg-ruby-extras/ruby-ole)
NOTE: Gem::Specification#has_rdoc= is deprecated with no replacement. It will be removed on or after 2011-10-01.
Gem::Specification#has_rdoc= called from (eval):23
.
/usr/bin/ruby1.8 -w -I"lib" "/usr/lib/ruby/1.8/rake/rake_test_loader.rb" "test/test_meta_data.rb" "test/test_filesystem.rb" "test/test_support.rb" "test/test_types.rb" "test/test_ranges_io.rb" "test/test_storage.rb" "test/test_property_set.rb" "test/test_mbat.rb"
./lib/ole/support.rb:39: warning: method redefined; discarding old to_proc
Loaded suite /usr/lib/ruby/1.8/rake/rake_test_loader
Started
..............................................................................
Finished in 1.074205 seconds.
78 tests, 302 assertions, 0 failures, 0 errors
terceiro@morere:~/src/debian/pkg-ruby-extras/ruby-ole ((debian/1.2.11.1-4))$ git checkout master
Previous HEAD position was f84a0b5... Merge in the previous incarnation packaging details
Switched to branch 'master'
terceiro@morere:~/src/debian/pkg-ruby-extras/ruby-ole (master)$ rake test
(in /home/terceiro/src/debian/pkg-ruby-extras/ruby-ole)
NOTE: Gem::Specification#has_rdoc= is deprecated with no replacement. It will be removed on or after 2011-10-01.
Gem::Specification#has_rdoc= called from (eval):23
.
/usr/bin/ruby1.8 -w -I"lib" "/usr/lib/ruby/1.8/rake/rake_test_loader.rb" "test/test_meta_data.rb" "test/test_filesystem.rb" "test/test_support.rb" "test/test_types.rb" "test/test_ranges_io.rb" "test/test_storage.rb" "test/test_property_set.rb" "test/test_mbat.rb"
./lib/ole/support.rb:39: warning: method redefined; discarding old to_proc
./lib/ole/types/property_set.rb:31: propids.yaml file could not be found (Exception)
from ./lib/ole/types.rb:2:in `require'
from ./lib/ole/types.rb:2
from ./lib/ole/storage/base.rb:6:in `require'
from ./lib/ole/storage/base.rb:6
from ./lib/ole/storage.rb:1:in `require'
from ./lib/ole/storage.rb:1
from ./test/test_meta_data.rb:6:in `require'
from ./test/test_meta_data.rb:6
from /usr/lib/ruby/1.8/rake/rake_test_loader.rb:5:in `load'
from /usr/lib/ruby/1.8/rake/rake_test_loader.rb:5
from /usr/lib/ruby/1.8/rake/rake_test_loader.rb:5:in `each'
from /usr/lib/ruby/1.8/rake/rake_test_loader.rb:5
rake aborted!
Command failed with status (1): [/usr/bin/ruby1.8 -w -I"lib" "/usr/lib/ruby...]
(See full trace by running task with --trace)
I guess you can add a new path to the search array there instead of replacing
the existing one.
Besides, please prepare an appropriate changelog entry so that the bug is
actualy marked as fixed when the package is uploaded.
Also, lintian complains about the versioned Conflicts: in debian/control,
perhaps you could turn those Conflicts: into Breaks: instead?
--
Antonio Terceiro <terceiro@softwarelivre.org>
http://softwarelivre.org/terceiro
Attachment:
signature.asc
Description: Digital signature