[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Review of package chef.



Hi Joshua, 

Yes looks neat and clean now :) and now lintain warning so far. I have also build with pbuilder and able to build successfully.

See log for more details.
http://pbuilder.wordpress.com/2010/05/28/chef_0-8-16-4_i386-dsc/


Thanks
Deepak

On Thu, May 27, 2010 at 10:49 PM, Joshua Timberman <joshua@opscode.com> wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello!

Thanks for the review. Tollef is involved in the Chef project community and had volunteered to sponsor. I pushed new packaging to both the repositories:

http://svn.debian.org/wsvn/pkg-ruby-extras/trunk/chef/debian/#_trunk_chef_debian_
http://github.com/opscode/opscode-packages/tree/master/debian/chef/debian/

The packages should be ready for Upload.

Thank you


On May 24, 2010, at 3:45 AM, Deepak Tripathi wrote:

Hi Joshua,

I have build chef from (svn+ssh://deepak-guest@svn.debian.org/svn/pkg-ruby-extras )  and found that there are couple of lintian errors/warnings are there.

see below lintian logs using ( lintian --info --display-info --display-experimental --pedantic --show-overrides --checksums --color auto)

--
I: chef source: missing-debian-source-format
N:
N:    Explicitly selecting a source format by putting the format in
N:    debian/source/format is recommended. This allows for future removal of
N:    the 1.0 default for the package source format and, depending on the
N:    source format, may allow unambiguous declaration of whether this package
N:    is native or non-native.
N:
N:    If you don't have a reason to stay with the old format for this package,
N:    please consider switching to "3.0 (quilt)" (for packages with a separate
N:    upstream tarball) or to "3.0 (native)" (for Debian native packages).
N:
N:    If you wish to keep using the old format, please create that file and
N:    put "1.0" in it to be explicit about the source package version. If you
N:    have problems with the 3.0 format, the dpkg maintainers are interested
N:    in hearing, at debian-dpkg@lists.debian.org, the (technical) reasons why
N:    the new formats do not suit you.
N:
N:    Refer to the dpkg-source(1) manual page and
N:    http://wiki.debian.org/Projects/DebSrc3.0 for details.
N:
N:    Severity: wishlist, Certainty: certain
N:
I: chef source: no-complete-debconf-translation
N:
N:    Even though this package provides debconf translation support, there are
N:    no translations or none of the translations are complete. This may mean
N:    that translators weren't properly warned about new strings.
N:
N:    Translators may be notified of changes using podebconf-report-po, for
N:    example:
N:
N:     podebconf-report-po --call --withtranslators --deadline="+10 days" \
N:     --languageteam
N:
N:    Refer to Debian Developer's Reference section 6.5.2.2 (Be kind to
N:    translators) for details.
N:
N:    Severity: wishlist, Certainty: possible
N:
E: chef: init.d-script-missing-dependency-on-remote_fs /etc/init.d/chef-server: required-start
N:
N:    The given init script seems to refer to /usr, possibly using a file or
N:    binary from there. Without a dependency on $remote_fs in Required-Start
N:    or Required-Stop, as appropriate, the init script might be run before
N:    /usr is mounted or after it's unmounted.
N:
N:    Using Should-Start or Should-Stop to declare the dependency is
N:    conceptually incorrect since the $remote_fs facility is always
N:    available. Required-Start or Required-Stop should be used instead. Also,
N:    please note that $all should not be used in Required-Stop, only
N:    Required-Start.
N:
N:    Refer to http://wiki.debian.org/LSBInitScripts for details.
N:
N:    Severity: important, Certainty: possible
N:
E: chef: init.d-script-missing-dependency-on-remote_fs /etc/init.d/chef-server: required-stop
P: chef: maintainer-script-without-set-e postinst
N:
N:    The maintainer script passes -e to the shell on the #! line rather than
N:    using set -e in the body of the script. This is fine for normal
N:    operation, but if the script is run by hand with sh /path/to/script
N:    (common in debugging), -e will not be in effect. It's therefore better
N:    to use set -e in the body of the script.
N:
N:    Refer to Debian Policy Manual section 10.4 (Scripts) for details.
N:
N:    Severity: pedantic, Certainty: certain
N:
P: chef: maintainer-script-without-set-e config
P: chef-solr: maintainer-script-without-set-e postinst
P: chef-solr: maintainer-script-without-set-e config
E: chef-solr: dir-or-file-in-var-run var/run/chef/
N:
N:    /var/run may be a temporary filesystem, so any directories or files
N:    needed there must be created dynamically at boot time.
N:
N:    Refer to Debian Policy Manual section 9.3.2 (Writing the scripts) for
N:    details.
N:
N:    Severity: serious, Certainty: possible
N:
E: chef-server: duplicate-updaterc.d-calls-in-postinst chef-server
N:
N:    The postinst script calls update-rc.d several times for the same
N:    /etc/init.d script.
N:
N:    Severity: important, Certainty: certain
N:
E: chef-server: duplicate-updaterc.d-calls-in-postrm chef-server
N:
N:    The postrm script calls update-rc.d several times for the same
N:    /etc/init.d script.
N:
N:    Severity: important, Certainty: certain
N:
E: chef-server: init.d-script-missing-dependency-on-remote_fs /etc/init.d/chef-server: required-start
E: chef-server: init.d-script-missing-dependency-on-remote_fs /etc/init.d/chef-server: required-stop
P: chef-server: maintainer-script-without-set-e postinst
P: chef-server-webui: maintainer-script-without-set-e postinst
P: chef-server-webui: maintainer-script-without-set-e config
---
Please fix them so that it will be in "Ready to upload" state.

I am changing debian/changelog mode to 'UNREALEASD' now.

--
Thanks
Deepak Tripathi
E3 71V3 8Y C063 (We Live By Code)
blog: http://deepaktripathi.blogspot.com
pbuilder log: http://pbuilder.wordpress.com

- --
Opscode, Inc
Joshua Timberman, Senior Solutions Engineer
C: 720.334.RUBY E: joshua@opscode.com

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (Darwin)

iEYEARECAAYFAkv+qaYACgkQO97WSdVpzT1N8QCggxbqNk4ayVcsNpJ+UY/zchTs
bQYAn2Hzoj21Q4ZCvKHUCW54sD4GWR7B
=jCb+
-----END PGP SIGNATURE-----



--
Deepak Tripathi
E3 71V3 8Y C063 (We Live By Code)
http://deepaktripathi.blogspot.com


Reply to: