Package: fish
Version: 4.2.1-2
Severity: serious
Tags: ftbfs, patch
User: debian-riscv@lists.debian.org
Usertags: riscv64
X-Debbugs-Cc: debian-riscv@lists.debian.org
Dear Maintainer,
The package has one FTBFS issue on riscv64 like:
```
...
Failed to match pattern: .*still.alive
complete.py:51: timeout from expect_re(".*still.alive")
Escaped buffer:
...
Failure:
The CHECK on line 16 wants:
prompt 0> echo hello
which failed to match line stdout:2:
prompt 0>
Context:
prompt 0> sleep 0.5 &
prompt 0> <= does not match CHECK on line 16: prompt 0> echo hello
fish: Job 1, 'sleep 0.5 &' has ended
prompt 0> echo hello world
Send job 1 'sleep 3 | cat &' to background
when running command:
/build/reproducible-path/fish-4.2.1/obj-riscv64-linux-gnu/fish /build/reproducible-path/fish-4.2.1/tests/checks/tmux-job.fish
tests/checks/tmux-job.fish ␛[31mFAILED␛[0m 28109 ms
...
Failure:
The CHECK on line 68 wants:
1
which failed to match line stdout:41:
function fish_prompt
Context:
[...] from line 46 (stdout:24):
...
```
See the full buildd log:
https://buildd.debian.org/status/fetch.php?pkg=fish&arch=riscv64&ver=4.2.1-2&stamp=1764008323&raw=0
I admit the timeout I increased were too excessive for some cases. Even so,
the build with the patch is not 100% successful. But I have confidence
to get it built on buildd. Please let me know any issue.
--
Regards,
--
Bo YU <yubo@iscas.ac.cn>
diff -Nru fish-4.2.1/debian/changelog fish-4.2.1/debian/changelog
--- fish-4.2.1/debian/changelog 2025-11-22 00:40:34.000000000 +0800
+++ fish-4.2.1/debian/changelog 2025-11-25 17:56:47.000000000 +0800
@@ -1,3 +1,10 @@
+fish (4.2.1-2.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Increase timeout and sleep on riscv64. (Closes: #-1)
+
+ -- Bo YU <vimer@debian.org> Tue, 25 Nov 2025 17:56:47 +0800
+
fish (4.2.1-2) unstable; urgency=medium
* Reinstate fix-libc-timespec.patch for armhf
diff -Nru fish-4.2.1/debian/patches/increase-timeout-on-rv64.patch fish-4.2.1/debian/patches/increase-timeout-on-rv64.patch
--- fish-4.2.1/debian/patches/increase-timeout-on-rv64.patch 1970-01-01 08:00:00.000000000 +0800
+++ fish-4.2.1/debian/patches/increase-timeout-on-rv64.patch 2025-11-25 17:56:47.000000000 +0800
@@ -0,0 +1,82 @@
+Description: increase timeout and sleep on riscv64
+Author: Bo YU<vimer@debian.org>
+Bug: https://buildd.debian.org/status/fetch.php?pkg=fish&arch=riscv64&ver=4.2.1-2&stamp=1764008323&raw=0
+Last-Update: 2025-11-25
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/tests/pexpects/complete.py
++++ b/tests/pexpects/complete.py
+@@ -18,16 +18,16 @@
+ sendline("complete -x -c monster -a energy=")
+ expect_prompt()
+ send("monster t")
+-sleep(0.1)
++sleep(10.1)
+ send("\t")
+-sleep(0.1)
++sleep(10.1)
+ send("!")
+ expect_str("monster truck !") # space
+ send("\b" * 64)
+ send("monster e")
+-sleep(0.1)
++sleep(10.1)
+ send("\t")
+-sleep(0.1)
++sleep(10.1)
+ send("!")
+ expect_str("monster energy=!") # no space
+ send("\b" * 64)
+--- a/tests/pexpects/job_summary.py
++++ b/tests/pexpects/job_summary.py
+@@ -30,7 +30,7 @@
+ # fish_job_summary is called when background job ends.
+ sendline("sleep 0.5 &")
+ expect_prompt()
+-expect_re("[0-9]+:0:sleep 0.5 &:ENDED", timeout=20)
++expect_re("[0-9]+:0:sleep 0.5 &:ENDED", timeout=40)
+ sendline("")
+ expect_prompt()
+
+@@ -48,7 +48,7 @@
+ m = expect_re("\\d+\r\n")
+ expect_prompt()
+ os.kill(int(m.group()), signal.SIGTERM)
+-expect_re("[0-9]+:0:sleep 20 &:SIGTERM:Polite quit request", timeout=20)
++expect_re("[0-9]+:0:sleep 20 &:SIGTERM:Polite quit request", timeout=40)
+ sendline("")
+ expect_prompt()
+
+--- a/tests/checks/tmux-job.fish
++++ b/tests/checks/tmux-job.fish
+@@ -8,9 +8,9 @@
+ sleep 0.1
+ isolated-tmux send-keys \
+ "echo hello"
+-sleep 0.6
++sleep 5.6
+ isolated-tmux send-keys Space world
+-sleep 0.1
++sleep 5.1
+ isolated-tmux capture-pane -p
+ # CHECK: prompt 0> sleep 0.5 &
+ # CHECK: prompt 0> echo hello
+--- a/tests/checks/tmux-prompt.fish
++++ b/tests/checks/tmux-prompt.fish
+@@ -51,6 +51,7 @@
+ end
+ ' C-l 'echo hello'
+ tmux-sleep
++tmux-sleep
+ isolated-tmux capture-pane -p
+ # CHECK: xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
+ # CHECK: echo hello
+@@ -64,6 +65,8 @@
+ end
+ ' Enter
+ tmux-sleep
++tmux-sleep
++tmux-sleep
+ isolated-tmux capture-pane -p -S -11
+ # CHECK: 1
+ # CHECK: 2
diff -Nru fish-4.2.1/debian/patches/series fish-4.2.1/debian/patches/series
--- fish-4.2.1/debian/patches/series 2025-11-22 00:33:40.000000000 +0800
+++ fish-4.2.1/debian/patches/series 2025-11-24 15:58:30.000000000 +0800
@@ -3,3 +3,4 @@
downgrade-phf-0.11.patch
disable-unix_path.patch
fix-libc-timespec.patch
+increase-timeout-on-rv64.patch
Attachment:
signature.asc
Description: PGP signature