[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1028600: postfix: ftbfs on riscv64



Source: postfix
Version: 3.7.3-3
Severity: important
Tags: ftbfs patch
Justification: fails to build from source (but built successfully in the past)
User: debian-riscv@lists.debian.org
Usertags: riscv64
X-Debbugs-Cc: debian-riscv@lists.debian.org

Dear Maintainer,

The package has a ftbfs on riscv64 arch due to:

```
./sys_defs.h:1264:2: error: #error "unsupported platform"
 1264 | #error "unsupported platform"
      |  ^~~~~
In file included from alldig.c:40:
./sys_defs.h:1264:2: error: #error "unsupported platform"
 1264 | #error "unsupported platform"
      |  ^~~~~
./sys_defs.h:1333:2: error: #error "define HAS_FCNTL_LOCK and/or HAS_FLOCK_LOCK"
 1333 | #error "define HAS_FCNTL_LOCK and/or HAS_FLOCK_LOCK"
      |  ^~~~~
In file included from argv.c:123:
./sys_defs.h:1264:2: error: #error "unsupported platform"
 1264 | #error "unsupported platform"
 ...
```

The full buildd log is here:
https://buildd.debian.org/status/fetch.php?pkg=postfix&arch=riscv64&ver=3.7.3-3&stamp=1673457275&raw=0

I checked the changes since [0]:
https://tracker.debian.org/news/1407943/accepted-postfix-373-3-source-into-unstable/
So I think we may forget to add support LINUX6 on src/util/sys_defs.h
file. So the patch is to this issue and I have tested it on my real
riscv64 hardware and amd64&s390x to promise not to break something.

BTW, The same issue also happens on the ia64, powerpc, ppc64 and sparc64 arch.
These FTBFS issues should be fixed by the patch also I think, but I did
not test it on these arches.

Please let me know if there is any issues.

BR,
Bo

-- 
Regards,
--
  Bo YU

diff -Nru postfix-3.7.3/debian/changelog postfix-3.7.3/debian/changelog
--- postfix-3.7.3/debian/changelog	2023-01-12 00:02:33.000000000 +0800
+++ postfix-3.7.3/debian/changelog	2023-01-13 20:58:02.000000000 +0800
@@ -1,3 +1,10 @@
+postfix (3.7.3-3.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix ftbfs on riscv64. (Closes: #-1) 
+
+ -- Bo YU <tsu.yubo@gmail.com>  Fri, 13 Jan 2023 20:58:02 +0800
+
 postfix (3.7.3-3) unstable; urgency=medium
 
   [Scott Kitterman]
diff -Nru postfix-3.7.3/debian/patches/support_linux6 postfix-3.7.3/debian/patches/support_linux6
--- postfix-3.7.3/debian/patches/support_linux6	2023-01-11 23:24:43.000000000 +0800
+++ postfix-3.7.3/debian/patches/support_linux6	2023-01-13 17:54:01.000000000 +0800
@@ -1,8 +1,6 @@
-Index: postfix/makedefs
-===================================================================
---- postfix.orig/makedefs
-+++ postfix/makedefs
-@@ -634,7 +634,7 @@ EOF
+--- a/makedefs
++++ b/makedefs
+@@ -634,7 +634,7 @@
  		: ${SHLIB_ENV="LD_LIBRARY_PATH=`pwd`/lib"}
  		: ${PLUGIN_LD="${CC-gcc} -shared"}
  		;;
@@ -11,3 +9,14 @@
  		case "$CCARGS" in
  		 *-DNO_DB*) ;;
  		 *-DHAS_DB*) ;;
+--- a/src/util/sys_defs.h
++++ b/src/util/sys_defs.h
+@@ -751,7 +751,7 @@
+  /*
+   * LINUX.
+   */
+-#if defined(LINUX2) || defined(LINUX3) || defined(LINUX4) || defined(LINUX5)
++#if defined(LINUX2) || defined(LINUX3) || defined(LINUX4) || defined(LINUX5) || defined(LINUX6)
+ #define SUPPORTED
+ #define UINT32_TYPE	unsigned int
+ #define UINT16_TYPE	unsigned short

Attachment: signature.asc
Description: PGP signature


Reply to: