[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#1028343: u-boot-qemu 2023.01~rc4+dfsg-2: riscv64: FDT creation failed

On 2023-01-11, Karsten Merker wrote:
> On Tue, Jan 10, 2023 at 09:22:02PM +0100 Karsten Merker wrote:
>> I've also taken a look at the u-boot changelogs and there have
>> been quite a few changes concerning u-boot's handling of
>> device-trees between the working and the non-working versions. 
>> Unfortunately I'm not familiar enough with the inner workings of
>> u-boot to understand the implications of several of these
>> changes.
> Hello,
> I've tried narrowing down the source of the issue by using
> git bisect on the u-boot tree and that has resulted in
> the following commit as the potential culprit:
>   commit a56f663f07073713042bb0fd08053aeb667e717b
>   Author: Simon Glass <sjg@chromium.org>
>   Date:   Thu Oct 20 18:23:14 2022 -0600
>     vbe: Add info about the VBE device to the fwupd node
>     At present we put the driver in the /chosen node in U-Boot. This is a bit
>     strange, since U-Boot doesn't normally use that node itself. It is better
>     to put it under the bootstd node.
>     To make this work we need to copy create the node under /chosen when
>     fixing up the device tree. Copy over all the properties so that fwupd
>     knows what to do.
>     Update the sandbox device tree accordingly.
>     Signed-off-by: Simon Glass <sjg@chromium.org>

Thanks for digging into this!

> I'm not sure whether this is the actual culprit or just an
> operation that happens to expose a problem elsewhere, though.
> I'm inclined to forward the bug report to u-boot upstream unless
> somebody has another idea how to get this narrowed down further.

Reverting just that commit seems doable (one smallish conflict) to test
with greater confidence, though as you say, it could just be revealing
other bugs.

I do not see any debian-specific patches that are likely to be relevent.

If it is annoyingly subtle, it might also be the intersection of
... particular qemu, opensbi and u-boot versions...

Definitely would be good to mention to upstream. Please Cc me if you do!
If you would rather I nudge this upstream, let me know.

live well,

Reply to: