[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#1014594: muse: FTBFS on riscv64



On Fri, 2022-07-08 at 13:46 +0000, Ileana Dumitrescu wrote:

> The attached patch fixes the issue, and I will create a merge request
> on the salsa repo at https://salsa.debian.org/multimedia-team/muse.

This patch introduces an embedded copy of CheckAtomic.cmake from the
extra-cmake-modules package but such copies are against Debian policy.

https://wiki.debian.org/EmbeddedCopies

Instead the package should build-depend on extra-cmake-modules and add
the relevant changes to the cmake files to load the CheckAtomic
functionality installed in the extra-cmake-modules package.
The ECM documentation mentions how to load the modules.

https://api.kde.org/ecm/manual/ecm.7.html

You can find examples of packages using ECM via Debian Code Search:

https://codesearch.debian.net/search?q=find_package.*ECM&literal=0

-- 
bye,
pabs

https://wiki.debian.org/PaulWise

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: