Re: Bug#1014392: mingw-w64: ftbfs on riscv64(error: #error Unknown CPU architecture!)

[Bo YU <tsu.yubo@gmail.com>]

Hi,
On Tue, Jul 05, 2022 at 10:47:26PM +0800, Paul Wise wrote:
> On Tue, 2022-07-05 at 17:42 +0800, Bo YU wrote:
>
> > The patch attached is to fix the issue and I can build the package
> > on my locally real riscv64 hardware(Unmatched board) with it.
> ...
> > +#elif defined(__riscv) && __riscv_xlen == 64
> > +# define WORDS_BIGENDIAN
>
> I don't think this patch is correct, riscv64 is little-endian.

Aha, yeah, sorry my bad.

To my surprise this definition doesn't seem to take effect,
Either define or undef can build riscv64 package here.

Bo
> --
> bye,
> pabs
>
> https://wiki.debian.org/PaulWise



--
Best Regards,

--- a/mingw-w64-tools/widl/include/basetsd.h
+++ b/mingw-w64-tools/widl/include/basetsd.h
@@ -36,7 +36,7 @@
  * 64-bit.
  */
 
-#if (defined(__x86_64__) || defined(__powerpc64__) || defined(__aarch64__) || defined(__sparc64__) || defined(__ia64__) || defined(__s390x__)) && !defined(_WIN64)
+#if (defined(__x86_64__) || defined(__powerpc64__) || defined(__aarch64__) || defined(__sparc64__) || defined(__ia64__) || defined(__s390x__) || defined(__riscv) && __riscv_xlen == 64) && !defined(_WIN64)
 #define _WIN64
 #endif
 
@@ -299,6 +299,8 @@
 # undef  WORDS_BIGENDIAN
 #elif defined(__s390__) || defined(__s390x__)
 # define WORDS_BIGENDIAN
+#elif defined(__riscv) && __riscv_xlen == 64
+# undef WORDS_BIGENDIAN
 #elif defined(__hppa__)
 # undef  WORDS_BIGENDIAN
 #elif !defined(RC_INVOKED) && !defined(__WIDL__) && !defined(__midl)

Attachment: signature.asc
Description: PGP signature