[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: lwatch riscv fix



On Thu, Dec 09, 2021 at 01:57:49PM +0000, Ileana Dumitrescu wrote:
> Hi,
> 
> I am trying to fix the package lwatch_0.6.2-1 so that it works on riscv. 

> debian/rules file currently calls: ./configure --host=$(DEB_HOST_GNU_TYPE)
> --build=$(DEB_BUILD_GNU_TYPE).  These environment variables come from
> dpkg-architecture which gives 'riscv64-linux-gnu'.  The package builds and
> compiles properly when running ./configure
> --host=riscv64-unknown-linux-gnu --build=riscv64-unknown-linux-gnu.  I
> have seen the 'unknown' part in these build/host strings before and am not
> sure what the difference is.

The package uses an obsolete version of config.{sub,guess} -- which fails to
recognize riscv64.  Autotools still think they live in 1980s' when it was a
good idea to include all helper tools in a source tarball.

> So it appears either dpkg-architecture is giving an incorrect string for
> this build, or the debian/rules file needs to be modified for lwatch
> specifically to allow it to work for riscv.  I can build the package by
> adding an if check for riscv and hard-coding the riscv64-unknown-linux-gnu
> strings in the configure part, but this does not feel like best practice. 

I see there's code to update config.{sub,guess} during build, but it's
commented out.

On the other hand, it'd be much better if you could just nuke current
debian/rules and replace it with dh, it looks like the only thing that
needs adjustment are args to configure.


Meow!
-- 
⢀⣴⠾⠻⢶⣦⠀ .--[ Makefile ]
⣾⠁⢠⠒⠀⣿⡁ # beware of races
⢿⡄⠘⠷⠚⠋⠀ all: pillage burn
⠈⠳⣄⠀⠀⠀⠀ `----


Reply to: