[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#895864: leptonlib: needs config.guess/sub update for riscv64



Hi,

2018-04-23 21:12 GMT+02:00 Jeff Breidenbach <jeff@jab.org>:
> Is it sufficient to put Build-Depends: debhelper (>= 11.0.0) in
> debian/control and 11 in debian/compat ?

Thanks for taking care of this.

You have to un-comment the "dh_autoreconf*" lines in debian/rules too,
not sure why they are disabled, but possibly because they don't work
(there's an error from libtoolize/autoconf).  It seems to need
additionally "pkg-config" in the build-depends, when reconfguring.

To the best of my knowledge, if you were using a rule like the
following one and without the handcrafted rules, I think that it would
be part of the commands invoked by default, but with the handcrafted
rules they take precedence, so the defaults are not invoked.

=============================
%:
        dh $@
=============================

The rule above covers the defaults of leptonlib quite well, since it's
not using anything contrived, only needs a minor modification for the
manpage.  Things like noopt and nostrip are supposed to be handled
automatically.

I attach 3 files:

1) the minimal conversion so dh-autoreconf works (leptonlib_1.75.3-3.1.debdiff)

2) and 3) the full conversion to simple rules, with
leptonlib_1.75.3-3.2.debdiff and debian/rules attached separate, to
see clearly the benefits.  (Obviously, by the way, the message in
d/changelog should be squashed).  This additionally runs the tests,
can be disabled with another override_dh_auto_test and leaving it
empty, but I recommend to enable them.


I tested 1 and 2/3 and it works fine, both produce binaries in amd64
that don't differ from the previous version (debdiff).


Hope that helps.  If in any doubt, please ask.


Cheers.
-- 
Manuel A. Fernandez Montecelo <manuel.montezelo@gmail.com>

Attachment: leptonlib_1.75.3-3.1.debdiff
Description: Binary data

Attachment: leptonlib_1.75.3-3.2.debdiff
Description: Binary data

Attachment: rules
Description: Binary data


Reply to: