Bug#894558: openssh: missing systemd support with the pkg.openssh.nognome profile

[Aurelien Jarno <aurel32@debian.org>]

Source: openssh
Version: 7.6p1-4
Severity: wishlist
Tags: patch
User: debian-riscv@lists.debian.org                                                                     
Usertags: riscv64

Hi,

Thanks a lot or adding the pkg.openssh.nognome, it really makes easier
bootstrapping a new architecture as openssh is one of the first things
you try to get to make your life easier.

Unfortunately it appears that when using this profile, systemd support
is not enabled. This causes the postinst script to fail when starting the
ssh server, even if in practice it is correctly started:

| Job for ssh.service failed because a timeout was exceeded.
| See "systemctl status ssh.service" and "journalctl -xe" for details.
| invoke-rc.d: initscript ssh, action "restart" failed.
| ● ssh.service - OpenBSD Secure Shell server
|    Loaded: loaded (/lib/systemd/system/ssh.service; enabled; vendor preset: enabled)
|    Active: activating (start-pre) since Sun 2018-04-01 09:45:27 CEST; 238ms ago
|   Process: 24693 ExecStart=/usr/sbin/sshd -D $SSHD_OPTS (code=exited, status=0/SUCCESS)
|  Main PID: 24693 (code=exited, status=0/SUCCESS); Control PID: 24697 (sshd)
|    CGroup: /system.slice/ssh.service
|            └─24697 /usr/sbin/sshd -t

It appears that systemd support requires pkg-config, and that this
build dependency is provided through libgtk-3-dev in the normal build,
and is therefore not installed when using the pkg.openssh.nognome
profile. The fix is therefore as simple as make the build-dependency,
like in the following patch:

--- a/debian/control	2018-04-01 13:49:23.527518848 +0200
+++ b/debian/control	2018-04-01 13:49:50.379552345 +0200
@@ -16,6 +16,7 @@
                libssl1.0-dev | libssl-dev (<< 1.1.0~),
                libsystemd-dev [linux-any],
                libwrap0-dev | libwrap-dev,
+               pkg-config,
                zlib1g-dev (>= 1:1.2.3),
 Standards-Version: 4.1.0
 Uploaders: Colin Watson <cjwatson@debian.org>,

Would it be possible to include it to the next upload?

Thanks,
Aurelien

-- System Information:
Debian Release: buster/sid
  APT prefers unreleased
  APT policy: (500, 'unreleased'), (500, 'unstable')
Architecture: riscv64

Kernel: Linux 4.15.0_riscv-linux-4.15_2b0aa1de4+ (SMP w/1 CPU core)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)