[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1098488: marked as done (freerdp3-x11: Enable fdk-aac to replace buggy aac encoder from ffmpeg)

Your message dated Tue, 9 Sep 2025 15:52:19 +0300
with message-id <e33f1bcc-e604-4cb4-94c2-884f93b60326@tls.msk.ru>
and subject line Re: Bug#1098488: freerdp3-x11: Enable fdk-aac to replace buggy aac encoder from ffmpeg
has caused the Debian Bug report #1098488,
regarding freerdp3-x11: Enable fdk-aac to replace buggy aac encoder from ffmpeg
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1098488: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1098488
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: freerdp3-x11
Version: 3.10.3+dfsg-1~bpo12+1
Severity: important
X-Debbugs-Cc: akallabeth+debian@posteo.net

Dear Maintainer,

the current package of FreeRDP uses the AAC encoder from FFMPEG.
This encoder does have an issue with certain PCM input data (specifics unknown)
and fails with

[aac @ 0x7f3cd4c307c0] Input contains (near) NaN/+-Inf
[aac @ 0x7f3cd4c307c0] Qavg: nan
[aac @ 0x7f3cd4c307c0] 2 frames left in the queue on closing

It looks like this is something internal wher formats are converted and a
division by zero occurs. (the input is INT16 PCM data, so no floating point
data from the FreeRDP side...)

since this prevents FreeRDP form using the /microphone option the only way to
work around this is currently to use /microphone:format:1 which disables
microphone data encoding and sends raw PCM data.
This requires a lot more bandwidth and should be avoided.

Upstream FreeRDP also supports the fdk-aac encoder which can be enabled with
-DWITH_FDK_AAC=ON during build.
Since this dependency is also in the repo it would be preferrable to have this
working AAC encoder compiled in instead of one bailing out on some input data.


-- System Information:
Debian Release: 12.9
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.12.9+bpo-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages freerdp3-x11 depends on:
ii  libc6                 2.36-9+deb12u9
ii  libfreerdp-client3-3  3.10.3+dfsg-1~bpo12+1
ii  libfreerdp3-3         3.10.3+dfsg-1~bpo12+1
ii  libwinpr3-3           3.10.3+dfsg-1~bpo12+1
ii  libx11-6              2:1.8.4-2+deb12u2
ii  libxcursor1           1:1.2.1-1
ii  libxext6              2:1.3.4-1+b1
ii  libxfixes3            1:6.0.0-2
ii  libxi6                2:1.8-1+b1
ii  libxinerama1          2:1.1.4-3
ii  libxrandr2            2:1.5.2-2+b1
ii  libxrender1           1:0.9.10-1.1

freerdp3-x11 recommends no packages.

freerdp3-x11 suggests no packages.

-- no debconf information

--- End Message ---
--- Begin Message --- 
Version: 3.13.0+dfsg-1
On Fri, 21 Feb 2025 16:30:56 +0000 akallabeth <akallabeth+debian@posteo.net> wrote:
ok, since the fdk-aac thing does not look like it is an option I did have a more detailed look at the issue on the ffmpeg side.
created https://github.com/FreeRDP/FreeRDP/pull/11225 which seems to work fine (just ignore errors from the encoder) 
This change landed in 3.13 upstream version.

While this is not the solution originally wanted, but it should
fix the issue.  Let's close this bug report.

Thanks,

/mjt

--- End Message ---
Reply to: