[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#888772: marked as done (xrdp FTCBFS: passes the empty string to -rpath)

Your message dated Fri, 30 Aug 2024 06:49:35 +0000
with message-id <E1sjvRv-008ww9-0D@fasolo.debian.org>
and subject line Bug#888772: fixed in xrdp 0.10.1-3
has caused the Debian Bug report #888772,
regarding xrdp FTCBFS: passes the empty string to -rpath
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
888772: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=888772
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: xrdp
Version: 0.9.5-1
Tags: patch
User: helmutg@debian.org
Usertags: rebootstrap

xrdp fails to cross build from source, because it passes an empty string
to -rpath and libtool doesn't like that. It turns out that $moduledir
ends up being empty, because it uses the wrong pkg-config to query for
it and doesn't trap failure from pkg-config. After fixing the relevant
configure.ac, the build moves along until the install-data-hook fails
running host tools. It turns out the effects of the install-data-hook
are nullified by the packaging, so we can just skip the whole hook.
After doing so, xrdp cross builds successfully. You can find the
cumulative changes in the attached patch.

Helmut

diff --minimal -Nru xrdp-0.9.5/debian/changelog xrdp-0.9.5/debian/changelog
--- xrdp-0.9.5/debian/changelog	2018-01-07 22:24:28.000000000 +0100
+++ xrdp-0.9.5/debian/changelog	2018-01-29 17:34:36.000000000 +0100
@@ -1,3 +1,12 @@
+xrdp (0.9.5-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
+    + cross.patch: Fix pkg-config usage.
+    + Avoid useless install-data-hook running host programs.
+
+ -- Helmut Grohne <helmut@subdivi.de>  Mon, 29 Jan 2018 17:34:36 +0100
+
 xrdp (0.9.5-1) unstable; urgency=medium
 
   * New upstream version.
diff --minimal -Nru xrdp-0.9.5/debian/patches/cross.patch xrdp-0.9.5/debian/patches/cross.patch
--- xrdp-0.9.5/debian/patches/cross.patch	1970-01-01 01:00:00.000000000 +0100
+++ xrdp-0.9.5/debian/patches/cross.patch	2018-01-29 17:34:16.000000000 +0100
@@ -0,0 +1,13 @@
+Index: xrdp-0.9.5/xorgxrdp/configure.ac
+===================================================================
+--- xrdp-0.9.5.orig/xorgxrdp/configure.ac
++++ xrdp-0.9.5/xorgxrdp/configure.ac
+@@ -29,7 +29,7 @@
+ if test "x$enable_strict_locations" = "xyes"; then
+   moduledir='${libdir}/xorg/modules'
+ else
+-  moduledir=`pkg-config xorg-server --variable=moduledir`
++  moduledir=`$PKG_CONFIG xorg-server --variable=moduledir`
+   sysconfdir="/etc"
+ fi
+ 
diff --minimal -Nru xrdp-0.9.5/debian/patches/series xrdp-0.9.5/debian/patches/series
--- xrdp-0.9.5/debian/patches/series	2018-01-07 15:55:20.000000000 +0100
+++ xrdp-0.9.5/debian/patches/series	2018-01-29 17:33:58.000000000 +0100
@@ -6,3 +6,4 @@
 systemd.diff
 lfs.diff
 pulse-debian.patch
+cross.patch
diff --minimal -Nru xrdp-0.9.5/debian/rules xrdp-0.9.5/debian/rules
--- xrdp-0.9.5/debian/rules	2018-01-07 17:07:53.000000000 +0100
+++ xrdp-0.9.5/debian/rules	2018-01-29 17:34:36.000000000 +0100
@@ -74,6 +74,10 @@
 	    xargs -0 perl -pi -e 's!XRDP_PID_PATH.*?/run!$$&/xrdp!g' --
 
 override_dh_auto_install:
+	# prevent install-data-hook from generating these
+	mkdir -p debian/xrdp/etc/xrdp
+	touch debian/xrdp/etc/xrdp/rsakeys.ini
+	touch debian/xrdp/etc/xrdp/cert.pem
 	dh_auto_install -v --destdir=debian/xrdp
 	# remove unused/confusing files
 	rm -f debian/xrdp/etc/xrdp/xrdp.sh

--- End Message ---
--- Begin Message --- 
Source: xrdp
Source-Version: 0.10.1-3
Done: Alex Myczko <tar@debian.org>

We believe that the bug you reported is fixed in the latest version of
xrdp, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 888772@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Alex Myczko <tar@debian.org> (supplier of updated xrdp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 30 Aug 2024 06:24:26 +0000
Source: xrdp
Architecture: source
Version: 0.10.1-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Remote Maintainers <debian-remote@lists.debian.org>
Changed-By: Alex Myczko <tar@debian.org>
Closes: 888772
Changes:
 xrdp (0.10.1-3) unstable; urgency=medium
 .
   * Fix FTCBFS: (Closes: #888772) (Thanks Helmut Grohne for the patch)
     + Avoid useless install-data-hook running host programs.
   * d/rules: disable tests.
Checksums-Sha1:
 78c4398c313b484781ddb34542d8727d0dfd031d 2249 xrdp_0.10.1-3.dsc
 b2b79b41934ee1da28b8fa72d0644ef356ee679c 37608 xrdp_0.10.1-3.debian.tar.xz
 8c0fe02b800c3b885efee7a61cfc4270b66e46dc 8776 xrdp_0.10.1-3_source.buildinfo
Checksums-Sha256:
 aa32428586373581551db63ff4a697de5536a6db7cc1f4414ee66eb527bd58b9 2249 xrdp_0.10.1-3.dsc
 cae60ccaec96310a1872e9477f4e5acd3a39527c6096530df8ba479de3ce214a 37608 xrdp_0.10.1-3.debian.tar.xz
 ea8e3700b836f167379b953363b17e0c34426a5bac93a88e188350f90bb5989f 8776 xrdp_0.10.1-3_source.buildinfo
Files:
 344f54af45138090864b505a2c74b0f1 2249 net optional xrdp_0.10.1-3.dsc
 f63f8196a0653713ae0d8ba132d456d9 37608 net optional xrdp_0.10.1-3.debian.tar.xz
 e2d1e7da94fc411a8650703821ed571c 8776 net optional xrdp_0.10.1-3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEtgob82PcExn/Co6JEWhSvN91FcAFAmbRaMYACgkQEWhSvN91
FcDrOA/+MYxt36VjJkebnDEzzXwJzIP3Ca/5JmIFL1L5Q6sCEcP5z0GwOwji4qZ3
D+QjnGAFr004n7m1ra8jyRT2cIfw2fwLUUcXbBekc0mEsNlNBq8ZvA3hR8Rv5YYH
NOZEd+DS6QpuHp4CZPLmYnPD10xiZMyzCS+CuyorAegYKnWPNq1uJ+AG9M6G9N8R
8W5B1CkTOrabCiB9psIt2cfmX9fx6yFRwpsFPASyJ6O+NmYyqvXj4/Ased8MRBNY
apEG3qxwrPpUQV4Y/m1RG5qGfAjrLF2uhwvyqMMO1XZO3MXGmo36KFuGG2eQUUyK
dl8PMt662Sn2wUGcyt/2cMvW6OZDZf4Z917D1AmW8YrDQDSiMH7Aa04rFMs4zxEQ
PUUjziyZFdAeLFpzpNEuonMUPOecQ/tUfCn3VLBEE3umgi/FujAXcFvjkC3GBt45
izN8GQzDdYT38R5QSWpcjm5VWdkuvZe6acC+qLEH6FSrGSLE3M6SmM09ZEiNL3/o
KRZHpdhjvPPRp2ylr1GhEe9r4sou89ignVXwjmLoHLZ3AiAjizFtPgzoVhOOW+CI
7CvspNESX7142q6C0rbDun1BoFpQM+wQDRUxvtE35ALLMit0WY/+wDhq/qHb0Vet
frCY0x3MRbCsE1amcpaA6OE3n5B0a/9iWgk9K0gW/xANcNSGf2A=
=LPXN
-----END PGP SIGNATURE-----

Attachment: pgpyXHGY2EA9s.pgp
Description: PGP signature


--- End Message ---
Reply to: