Bug#1036396: unblock: x2gothinclient/1.5.0.1-10
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: x2gothinclient@packages.debian.org, sunweaver@debian.org
Control: affects -1 + src:x2gothinclient
Please unblock package x2gothinclient
[ Reason ]
In the context of #1035654, five source packages (including this one)
still fail to purge remove without adduser installed.
[ Impact ]
We want to avoid the situation where a user removes the package, then
upgrades to apt that doesn't depend on adduser, then removes adduser and
then attempts to purge this package.
[ Tests ]
See the script I posted in #1035654.
[ Risks ]
Low risk due to trivial changes (see end of this mail) and because of
low popcon number (36 votes).
In addition to the adduser changes, the diff to testing also includes removal
of lsb-base and policykit-1 (in favour of polkitd). I'll leave it up to the
release team whether those additional changes on top of the adduser changes are
permitted or whether they should be reverted before granting the unblock
request.
[ Checklist ]
[x] all changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in testing
unblock x2gothinclient/1.5.0.1-10
diff -Nru x2gothinclient-1.5.0.1/debian/changelog x2gothinclient-1.5.0.1/debian/changelog
--- x2gothinclient-1.5.0.1/debian/changelog 2022-10-15 12:58:17.000000000 +0200
+++ x2gothinclient-1.5.0.1/debian/changelog 2023-05-19 10:59:29.000000000 +0200
@@ -1,9 +1,19 @@
-x2gothinclient (1.5.0.1-8.1) unstable; urgency=medium
+x2gothinclient (1.5.0.1-10) unstable; urgency=medium
- * Non-maintainer upload.
- * No source change upload to rebuild with debhelper 13.10.
+ * debian/changelog:
+ + Fix wrong bug closure in upload of 1.5.0.1-9.
- -- Michael Biebl <biebl@debian.org> Sat, 15 Oct 2022 12:58:17 +0200
+ -- Mike Gabriel <sunweaver@debian.org> Fri, 19 May 2023 10:59:29 +0200
+
+x2gothinclient (1.5.0.1-9) unstable; urgency=medium
+
+ * debian/x2gothinclient-common.postrm:
+ + Ignore failures during execution of deluser/delgroup. (Closes: #1034755).
+ * debian/control:
+ + Drop from D: lsb-base (obsoleted package). Thanks, lintian.
+ + Drop from D: policykit-1, replace by polkitd. Thanks, lintian.
+
+ -- Mike Gabriel <sunweaver@debian.org> Tue, 16 May 2023 22:09:06 +0200
x2gothinclient (1.5.0.1-8) unstable; urgency=medium
diff -Nru x2gothinclient-1.5.0.1/debian/control x2gothinclient-1.5.0.1/debian/control
--- x2gothinclient-1.5.0.1/debian/control 2022-10-03 11:54:53.000000000 +0200
+++ x2gothinclient-1.5.0.1/debian/control 2023-05-16 22:14:12.000000000 +0200
@@ -56,7 +56,6 @@
${misc:Pre-Depends},
Depends:
${misc:Depends},
- lsb-base,
nfs-common,
patch,
plymouth,
@@ -66,7 +65,7 @@
dbus-user-session,
x2gothinclient-displaymanager | x2gothinclient-minidesktop,
locales,
- policykit-1,
+ polkitd,
Recommends:
acpid,
gnupg-agent,
@@ -187,14 +186,13 @@
${misc:Pre-Depends},
Depends:
${misc:Depends},
- lsb-base,
psmisc,
pinentry-x2go,
xauth,
xinit,
locales,
dbus-x11,
- policykit-1,
+ polkitd,
libfile-path-expand-perl,
x2gothinclient-common (>= ${source:Version}), x2gothinclient-common (<< ${source:Version}.1),
Provides:
@@ -265,7 +263,6 @@
Depends:
${shlibs:Depends},
${misc:Depends},
- lsb-base,
lsscsi,
eject,
libfile-path-expand-perl,
diff -Nru x2gothinclient-1.5.0.1/debian/x2gothinclient-common.postrm x2gothinclient-1.5.0.1/debian/x2gothinclient-common.postrm
--- x2gothinclient-1.5.0.1/debian/x2gothinclient-common.postrm 2019-12-13 12:28:29.000000000 +0100
+++ x2gothinclient-1.5.0.1/debian/x2gothinclient-common.postrm 2023-05-16 22:07:53.000000000 +0200
@@ -17,8 +17,8 @@
case "$1" in
purge)
- getent passwd x2gothinclient >/dev/null && deluser x2gothinclient
- getent group x2gothinclient >/dev/null && delgroup x2gothinclient
+ getent passwd x2gothinclient >/dev/null && deluser x2gothinclient || true
+ getent group x2gothinclient >/dev/null && delgroup x2gothinclient || true
rm -Rf /var/lib/x2gothinclient
Reply to: