[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1005159: xrdp: please also source ~/.profile in startwm.sh



Package: xrdp
Version: 0.9.17-2
Severity: normal
Tags: patch

Hi,

/etc/xrdp/startwm.sh doesn't source $HOME/.profile, which results in
$HOME/.local/bin not being in $PATH when a terminal is opened (most
terminals execute non-login shells by default).

GDM does it in /etc/gdm3/Xsession, and I guess it's also implicitly done
by startx too (since a console login is a login shell, so ~/.profile
would be sourced, and $PATH would be inherited by terminals opened in
the X server started by startx; I didn't test this but this seems logical), so I think it's safe.

I tried on my PC by directly modifying /etc/xrdp/startwm.sh and this
worked as intended, with no visible side-effects.

Thanks !

Regards,

--
Raphaël Halimi
From c8fdd8a7f3f151fd9269e59b57ba7280afcee360 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Halimi?= <raphael.halimi@gmail.com>
Date: Mon, 7 Feb 2022 20:35:10 +0100
Subject: [PATCH] startwm.sh: source ~/.profile too

---
 debian/startwm.sh | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/debian/startwm.sh b/debian/startwm.sh
index 3127740a..a1d08c1a 100755
--- a/debian/startwm.sh
+++ b/debian/startwm.sh
@@ -10,5 +10,9 @@ if test -r /etc/profile; then
 	. /etc/profile
 fi
 
+if test -r $HOME/.profile; then
+	. $HOME/.profile
+fi
+
 test -x /etc/X11/Xsession && exec /etc/X11/Xsession
 exec /bin/sh /etc/X11/Xsession
-- 
2.34.1

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


Reply to: