[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Ogon packaging for Debian (was: Re: Bug#906072: Ogon packages available (Linux RDP Server))



Hi Marcel,

On  So 21 Jun 2020 19:55:06 CEST, marcel wrote:

June 20, 2020 6:54 PM, "Mike Gabriel" <mike.gabriel@das-netzwerkteam.de> wrote:

btw. if you think that there is any pkg ready for review and upload, let me know.

Can you also provide an upload order list that is based on what src:pkg build-depends on what other
src:pkg?

Greets,
Mike

Hi Mike,

first compile run ("unstable") is finished.
Packages are uploaded (but not yet tested).

sources.list:
deb http://www.linux-ng.de/reprepro/ unstable main

Repo key:
http://www.linux-ng.de/reprepro/Release.key

Dependency list (let me know if there's a specific format for that):
http://www.linux-ng.de/reprepro/order.txt

Hope I can spent some time to test the packages within the next days.

Bye,
  Marcel

I just looked into src:pkg ogon. The package builds and creates DEBs all fine.

I have changed the version from 1.0.1~git... to 1.0.0+git.... (the upstream release number is not our realm, it's upstream's). I haven't committed + pushed this, yet:

```
[mike@minobo ogon (master)]$ git diff
diff --git a/debian/changelog b/debian/changelog
index 390d3e2..adb4c8f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,4 +1,4 @@
-ogon (1.0.1~git20200423.54334c1-1) UNRELEASED; urgency=medium
+ogon (1.0.0+git20200423.54334c1-1) UNRELEASED; urgency=medium

   * Update to latest git

diff --git a/debian/rules b/debian/rules
index 2cd0dcb..9293062 100755
--- a/debian/rules
+++ b/debian/rules
@@ -97,3 +97,6 @@ override_dh_installpam:
 override_dh_installinit:
        dh_installinit -p ogon-core --name ogon-rdp-server
        dh_installinit -p ogon-core --name ogon-session-manager
+
+get-orig-source:
+ uscan --noconf --force-download --rename --download-current-version --destdir=..
diff --git a/debian/watch b/debian/watch
index 0924bfc..5670a58 100644
--- a/debian/watch
+++ b/debian/watch
@@ -1,4 +1,4 @@
 version=4
-opts="mode=git, date=%Y%m%d, pretty=1.0.1~git%cd.%h, pgpmode=none" https://github.com/ogon-project/ogon.git HEAD debian uupdate +opts="mode=git, date=%Y%m%d, pretty=1.0.0+git%cd.%h, pgpmode=none" https://github.com/ogon-project/ogon.git HEAD debian uupdate #opts="mode=git, date=format:%Y%m%d, pretty=1.0.1~git%cd.%h, pgpmode=none" https://github.com/ogon-project/ogon.git HEAD debian uupdate #opts="mode=git" http://github.com/ogon-project/ogon.git refs/tags/v([\d\.]+) debian uupdate
```

But now we get to fine-tuning. When I run a critical lintian check on it, I get the listed issues (see below).

Main issue: we must not install to /opt.

I can go over them and get them +/- all solved, if you like. But for your learning process, it might make sense if I leave fixing those packaging issues (partially formalisms, partially technical) to you.

I have already added some comments (starting with :::). Let me know which way to go.

Greets,
Mike


```
E: libogon-backend1: dir-or-file-in-opt opt/ogon/
N:
N:    Debian packages should not install into /opt, because it is reserved for
N:    add-on software.
N:
N:    Refer to Filesystem Hierarchy Standard (/opt : Add-on application
N:    software packages) for details.
N:
N:    Severity: error
N:
N:    Check: files/hierarchy-standard
N:
E: libogon-backend1: dir-or-file-in-opt opt/ogon/lib/
E: libogon-backend1: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/
E: libogon-backend1: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/libogon-backend.so.1 E: libogon-backend1: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/libogon-backend.so.1.0.0
E: libogon-backend1: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/ogon1/
E: libogon-backend1: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/ogon1/modules/ E: libogon-backend1: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/ogon1/modules/libogon-mod-qt.so E: libogon-backend1: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/ogon1/modules/libogon-mod-weston.so E: libogon-backend1: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/ogon1/modules/libogon-mod-x11.so
E: ogon-core: dir-or-file-in-opt opt/ogon/
E: ogon-core: dir-or-file-in-opt opt/ogon/bin/
E: ogon-core: dir-or-file-in-opt opt/ogon/bin/ogon-cli
E: ogon-core: dir-or-file-in-opt opt/ogon/bin/ogon-snmon
E: ogon-core: dir-or-file-in-opt opt/ogon/bin/ogon-start-vc.sh
E: ogon-core: dir-or-file-in-opt opt/ogon/lib/
E: ogon-core: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/
E: ogon-core: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/ogon1/
E: ogon-core: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/ogon1/auth/
E: ogon-core: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/ogon1/auth/libogon-auth-pam.so E: ogon-core: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/ogon1/libogon-otsapi.so
E: ogon-core: dir-or-file-in-opt opt/ogon/sbin/
E: ogon-core: dir-or-file-in-opt opt/ogon/sbin/ogon-backend-launcher
E: ogon-core: dir-or-file-in-opt opt/ogon/sbin/ogon-get-openh264-codec
E: ogon-core: dir-or-file-in-opt opt/ogon/sbin/ogon-rdp-server
E: ogon-core: dir-or-file-in-opt opt/ogon/sbin/ogon-session-manager
E: ogon-dev: dir-or-file-in-opt opt/ogon/
E: ogon-dev: dir-or-file-in-opt opt/ogon/include/
E: ogon-dev: dir-or-file-in-opt opt/ogon/include/ogon1/
E: ogon-dev: dir-or-file-in-opt opt/ogon/include/ogon1/ogon/
E: ogon-dev: dir-or-file-in-opt opt/ogon/include/ogon1/ogon/api.h
E: ogon-dev: dir-or-file-in-opt opt/ogon/include/ogon1/ogon/backend.h
E: ogon-dev: dir-or-file-in-opt opt/ogon/include/ogon1/ogon/build-config.h
E: ogon-dev: dir-or-file-in-opt opt/ogon/include/ogon1/ogon/dmgbuf.h
E: ogon-dev: dir-or-file-in-opt opt/ogon/include/ogon1/ogon/message.h
E: ogon-dev: dir-or-file-in-opt opt/ogon/include/ogon1/ogon/module.h
E: ogon-dev: dir-or-file-in-opt opt/ogon/include/ogon1/ogon/service.h
E: ogon-dev: dir-or-file-in-opt opt/ogon/include/ogon1/ogon/version.h
E: ogon-dev: dir-or-file-in-opt opt/ogon/lib/
E: ogon-dev: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/
E: ogon-dev: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/cmake/
E: ogon-dev: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/cmake/ogon-backend1/ E: ogon-dev: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/cmake/ogon-backend1/ogon-backend-relwithdebinfo.cmake E: ogon-dev: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/cmake/ogon-backend1/ogon-backend.cmake E: ogon-dev: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/cmake/ogon-backend1/ogon-backendConfig.cmake E: ogon-dev: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/cmake/ogon-backend1/ogon-backendConfigVersion.cmake
E: ogon-dev: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/cmake/ogon1/
E: ogon-dev: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/cmake/ogon1/ogonConfig.cmake E: ogon-dev: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/cmake/ogon1/ogonConfigVersion.cmake E: ogon-dev: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/libogon-backend.so
E: ogon-dev: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/pkgconfig/
E: ogon-dev: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/pkgconfig/ogon-backend1.pc E: ogon-dev: dir-or-file-in-opt opt/ogon/lib/x86_64-linux-gnu/pkgconfig/ogon1.pc
E: ogon-dev: dir-or-file-in-opt opt/ogon/share/
E: ogon-dev: dir-or-file-in-opt opt/ogon/share/ogon/
E: ogon-dev: dir-or-file-in-opt opt/ogon/share/ogon/1/
E: ogon-dev: dir-or-file-in-opt opt/ogon/share/ogon/1/protobuf/
E: ogon-dev: dir-or-file-in-opt opt/ogon/share/ogon/1/protobuf/ICP.proto
E: ogon-dev: dir-or-file-in-opt opt/ogon/share/ogon/1/protobuf/Module.proto
E: ogon-dev: dir-or-file-in-opt opt/ogon/share/ogon/1/protobuf/SBP.proto
E: ogon-dev: dir-or-file-in-opt opt/ogon/share/ogon/1/protobuf/backend.proto
E: ogon-dev: dir-or-file-in-opt opt/ogon/share/ogon/1/protobuf/pbRPC.proto
E: ogon-dev: dir-or-file-in-opt opt/ogon/share/ogon/1/thrift/
E: ogon-dev: dir-or-file-in-opt opt/ogon/share/ogon/1/thrift/otsapi.thrift
E: libogon-backend1: package-modifies-ld.so-search-path etc/ld.so.conf.d/ogon-x86_64-linux-gnu.conf
N:
N:    This package installs a file in /etc/ld.so.conf.d, presumably to modify
N:    the search path of the run-time linker, and does not appear to be part
N:    of libc.
N:
N:    Packages containing shared libraries should either install them into
N:    /usr/lib or should require binaries built against them to set RPATH to
N:    find the library at run-time. Installing libraries in a different
N:    directory and modifying the run-time linker path is equivalent to
N:    installing them into /usr/lib except now conflicting library packages
N:    may cause random segfaults and difficult-to-debug problems instead of
N:    conflicts in the package manager.
N:
N:    Refer to Debian Policy Manual section 10.2 (Libraries) for details.
N:
N:    Severity: error
N:
N:    Check: files/ld-so
N:
E: ogon changes: unreleased-changes

::: IGNORE THIS ONE... I will go away once it is ready for release.

N:
N:    The distribution in the Changes field copied from debian/changelog
N:    indicates that this package was not intended to be released yet.
N:
N:    Refer to https://bugs.debian.org/542747 for details.
N:
N:    Severity: error
N:
N:    Check: changes-file
N:
W: ogon-core: command-with-path-in-maintainer-script postinst:6 /usr/sbin/ldconfig.real
N:
N:    The indicated program run in a maintainer script has a prepended path.
N:    Programs called from maintainer scripts normally should not have a path
N:    prepended. dpkg ensures that the PATH is set to a reasonable value, and
N:    prepending a path may prevent the local administrator from using a
N:    replacement version of a command for some local reason.
N:
N:    If the path is used to test a program for existence, please use if which
N:    $program > /dev/null; then ….
N:
N:    If you intend to override this tag, please make sure that you are in
N:    control of the installation path of the according program and that you
N:    won't forget to change this maintainer script, too, if you ever move
N:    that program around.
N:
N:    Refer to Debian Policy Manual section 6.1 (Introduction to package
N:    maintainer scripts), Debian Developer's Reference section 6.4 (Best
N:    practices for maintainer scripts), https://bugs.debian.org/769845,
N:    https://bugs.debian.org/807695, and
N:    https://lists.debian.org/debian-devel/2014/11/msg00044.html for details.
N:
N:    Severity: warning
N:
N:    Check: scripts
N:
W: ogon source: debian-rules-uses-unnecessary-dh-argument dh ... --with=systemd (line 42)
N:
N:    The debian/rules file passes the specified argument to dh $@ but it is
N:    enabled by default from this debhelper compatibility level onwards.
N:
N:    Please remove the argument from the call to dh(1).
N:
N:    Refer to the debhelper(7) manual page and the dh(1) manual page for
N:    details.
N:
N:    Severity: warning
N:
N:    Check: debhelper
N:
W: ogon-all: empty-binary-package

::: urgh, why empty???

N:    This binary package appears to be empty, and its description does not
N:    say that it's a metapackage or a transitional package. This is often due
N:    to problems with updating debhelper *.install files during package
N:    renames or similar problems where installation rules don't put files in
N:    the correct place.
N:
N:    If the package is deliberately empty, please mention in the package long
N:    description one of the phrases "metapackage", "dummy", "dependency
N:    package", or "empty package".
N:
N:    Previously, Lintian also accepted the use of "virtual package". This was
N:    removed to avoid overloading the term. If you have been relying on the
N:    phrase "virtual package" to avoid this warning, please replace it with
N:    one of the others.
N:
N:    Severity: warning
N:
N:    Check: files/empty-package
N:
W: libogon-backend1: initial-upload-closes-no-bugs

::: We should close the ITP in d/changelog

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=906072

N:    This package appears to be the first packaging of a new upstream
N:    software package (there is only one changelog entry and the Debian
N:    revision is 1), but it does not close any bugs. The initial upload of a
N:    new package should close the corresponding ITP bug for that package.
N:
N:    This warning can be ignored if the package is not intended for Debian or
N:    if it is a split of an existing Debian package.
N:
N:    Refer to Debian Developer's Reference section 5.1 (New packages) for
N:    details.
N:
N:    Severity: warning
N:
N:    Check: debian/changelog
N:
W: libogon-backend1-dbg: initial-upload-closes-no-bugs

::: see above

W: ogon-all: initial-upload-closes-no-bugs

::: see above

W: ogon-core: maintscript-calls-ldconfig postinst
N:
N:    The given maintainer script calls ldconfig. However, explicit calls in
N:    maintainer scripts should be replaced by a dpkg trigger.
N:
N:    Please replace the "ldconfig" call with an activate-noawait ldconfig
N:    trigger. With debhelper it is usually sufficient to simply add that line
N:    to debian/<package>.triggers.
N:
N:    If you use debhelper, this warning will appear if the package was
N:    compiled with debhelper before 9.20151004. Assuming all ldconfig
N:    invocations have been added by debhelper, this warning will disappear
N:    once the package is rebuilt with a newer version of debhelper.
N:
N:    Refer to https://lists.debian.org/debian-devel/2015/08/msg00412.html for
N:    details.
N:
N:    Severity: warning
N:
N:    Check: shared-libs
N:
W: ogon source: no-nmu-in-changelog

::: I will add myself to Uploaders: field.

N:    When you NMU a package, that fact should be mentioned on the first line
N:    in the changelog entry. Use the words "NMU" or "Non-maintainer upload"
N:    (case insensitive).
N:
N:    Maybe you didn't intend this upload to be a NMU, in that case, please
N:    double-check that the most recent entry in the changelog is
N:    byte-for-byte identical to the maintainer or one of the uploaders. If
N:    this is a local package (not intended for Debian), you can suppress this
N:    warning by putting "local" in the version number or "local package" on
N:    the first line of the changelog entry.
N:
N:    Refer to Debian Developer's Reference section 5.11.3 (Using the DELAYED/
N:    queue) for details.
N:
N:    Severity: warning
N:
N:    Check: nmu
N:
W: libogon-backend1: package-has-unnecessary-activation-of-ldconfig-trigger
N:
N:    The package activates the ldconfig trigger even though no shared
N:    libraries are installed in a directory controlled by the dynamic library
N:    loader.
N:
N:    Note this may be triggered by a bug in debhelper, that causes it to
N:    auto-generate an ldconfig trigger for packages that do not need it.
N:
N:    Refer to Debian Policy Manual section 8.1.1 (ldconfig) and
N:    https://bugs.debian.org/204975 for details.
N:
N:    Severity: warning
N:
N:    Check: shared-libs
N:
W: libogon-backend1-dbg: priority-extra-is-replaced-by-priority-optional
N:
N:    Since Debian Policy version 4.0.1, the priority extra has been
N:    deprecated.
N:
N:    Please update debian/control and replace all instances of Priority:
N:    extra with Priority: optional.
N:
N:    Refer to Debian Policy Manual section 2.5 (Priorities) for details.
N:
N:    Severity: warning
N:
N:    Check: fields/priority
N:
W: ogon-core-dbg: priority-extra-is-replaced-by-priority-optional
W: ogon source: source-nmu-has-incorrect-version-number 1.0.0+git20200423.54334c1-1

::: IGNORE this one, it will go away when I am uploader.

N:    A source NMU should have a Debian revision of "-x.x" (or "+nmuX" for a
N:    native package). This is to prevent stealing version numbers from the
N:    maintainer.
N:
N:    Maybe you didn't intend this upload to be a NMU, in that case, please
N:    double-check that the most recent entry in the changelog is
N:    byte-for-byte identical to the maintainer or one of the uploaders. If
N:    this is a local package (not intended for Debian), you can suppress this
N:    warning by putting "local" in the version number or "local package" on
N:    the first line of the changelog entry.
N:
N:    Refer to Debian Developer's Reference section 5.11.2 (NMUs and
N:    debian/changelog) for details.
N:
N:    Severity: warning
N:
N:    Check: nmu
N:
I: ogon source: debian-control-has-obsolete-dbg-package libogon-backend1-dbg
N:
N:    The debian/control file includes declaration of -dbg package.
N:
N:    Debug package are now autogenerated avoiding waste of miror space.
N:
N:    Please note that -dbg should be dropped from control file and must not
N:    be transitioned to a dummy package depending on -dbgsym.
N:
N:    Refer to https://wiki.debian.org/AutomaticDebugPackages for details.
N:
N:    Severity: info
N:
N:    Check: debian/control
N:
I: ogon source: debian-control-has-obsolete-dbg-package ogon-core-dbg
I: ogon source: debian-rules-contains-unnecessary-get-orig-source-target

::: I love get-orig-source targets in debian/rules, so I have added one

N:    This package's debian/rules file contains a get-orig-source target that
N:    appears to be unnecessary. For example, the package might simply contain
N:    a single call to uscan(1).
N:
N:    Such calls are not ideal; maintainers should be able to call uscan with
N:    their own choice of options and they additionally encourage the
N:    proliferation of boilerplate code across the archive.
N:
N:    Since Debian Policy 4.1.4, packages are encouraged to migrate to uscan
N:    and a Files-Excluded header in the debian/copyright file.
N:
N:    Refer to the uscan(1) manual page for details.
N:
N:    Severity: info
N:
N:    Check: debian/rules
N:
I: ogon source: debug-package-for-multi-arch-same-pkg-not-coinstallable libogon-backend1-dbg => libogon-backend1
N:
N:    The debug package appear to be containing debug symbols for a
N:    "Multi-Arch: same" package, but the debug package itself is not
N:    "Multi-Arch: same". If so, it is not possible to have the debug symbols
N:    for all architecture variants of the binaries available at the same
N:    time.
N:
N:    Making a debug package co-installable with itself is very trivial, when
N:    installing the debug symbols beneath:
N:      /usr/lib/debug/.build-id/<XX>/<rest-id>.debug
N:
N:    dh_strip does this in debhelper compat 9. Otherwise, the expected
N:    location of the debug symbols of a given ELF binary can be determined by
N:    using:
N:
N:     readelf -n <binary-elf> | \
N: perl -ne 'print if s,^\s*Build ID:\s*(\S\S)(\S+),/usr/lib/debug/.build-id/$1/$2.debug,'
N:
N:    Severity: info
N:
N:    Check: group-checks
N:
I: ogon source: duplicate-short-description libogon-backend1 libogon-backend1-dbg
N:
N:    The listed binary packages all share the same short description (the
N:    first line of the Description control field). The package names may
N:    provide enough additional information to distinguish between the
N:    packages, but it's common to also add a word or two to the short
N:    description to clarify the difference.
N:
N:    Severity: info
N:
N:    Check: debian/control
N:
I: ogon source: duplicate-short-description ogon-core ogon-all ogon-dev ogon-core-dbg
I: ogon-core: init.d-script-does-not-provide-itself etc/init.d/ogon-rdp-server
N:
N:    This /etc/init.d script indicates it provides one or more facilities,
N:    but none of the provided facilities match the name of the init script.
N:    In certain cases, it may be necessary to not follow that convention, but
N:    normally init scripts should always provide a facility matching the name
N:    of the init script.
N:
N:    Refer to https://wiki.debian.org/LSBInitScripts for details.
N:
N:    Severity: info
N:
N:    Check: init.d
N:
X: ogon-all: package-contains-no-arch-dependent-files
N:
N:    The package is not marked architecture all, but all the files it ships
N:    are installed in /usr/share.
N:
N:    Most likely this package should be marked architecture all, but there is
N:    a chance that the package is missing files.
N:
N:    Refer to Debian Policy Manual section 5.6.8 (Architecture) for details.
N:
N:    Severity: info
N:
N:    Check: files/architecture
N:
N:    This tag is experimental. Please file a bug report if the tag seems
N:    wrong.
N:
X: ogon-dev: package-contains-no-arch-dependent-files
I: ogon source: quilt-patch-using-template-description 01-NoDownloadThrift.patch
N:
N:    The patch contains a standard DEP 3 template description included by
N:    dpkg-source(1). Please consider replacing the template with a real
N:    description. You can edit the description by using quilt header -e when
N:    the patch is at the top of the stack. Alternatively, editing the patch
N:    in most text editors should work as well.
N:
N:    Refer to https://dep-team.pages.debian.net/deps/dep3/ for details.
N:
N:    Severity: info
N:
N:    Check: patch-systems
N:
I: ogon source: quilt-patch-using-template-description 08-new-start-vc.patch
I: ogon-core: spelling-error-in-binary opt/ogon/bin/ogon-cli Unkown Unknown
N:
N:    Lintian found a spelling error in the given binary. Lintian has a list
N:    of common misspellings that it looks for. It does not have a dictionary
N:    like a spelling checker does.
N:
N:    If the string containing the spelling error is translated with the help
N:    of gettext or a similar tool, please fix the error in the translations
N:    as well as the English text to avoid making the translations fuzzy. With
N:    gettext, for example, this means you should also fix the spelling
N:    mistake in the corresponding msgids in the *.po files.
N:
N:    You can often find the word in the source code by running:
N:
N:     grep -rw <word> <source-tree>
N:
N:    This tag may produce false positives for words that contain non-ASCII
N:    characters due to limitations in strings.
N:
N:    Severity: info
N:
N:    Check: binaries
N:
I: ogon-core: spelling-error-in-binary opt/ogon/lib/x86_64-linux-gnu/ogon1/libogon-otsapi.so unkown unknown I: ogon-core: spelling-error-in-binary opt/ogon/sbin/ogon-backend-launcher Unkown Unknown I: ogon-core: spelling-error-in-binary opt/ogon/sbin/ogon-rdp-server connnection connection I: ogon-core: spelling-error-in-binary opt/ogon/sbin/ogon-rdp-server informations information I: ogon-core: spelling-error-in-binary opt/ogon/sbin/ogon-rdp-server occured occurred I: ogon-core: spelling-error-in-binary opt/ogon/sbin/ogon-session-manager Unkown Unknown I: ogon-core: spelling-error-in-binary opt/ogon/sbin/ogon-session-manager aditional additional I: ogon-core: spelling-error-in-binary opt/ogon/sbin/ogon-session-manager dont don't I: ogon-core: spelling-error-in-binary opt/ogon/sbin/ogon-session-manager registred registered I: ogon-core: systemd-service-file-missing-documentation-key lib/systemd/system/ogon-rdp-server.service
N:
N:    The systemd service file does not contain a Documentation key.
N:
N:    Documentation for systemd service files can be automatically viewed
N:    using systemctl help servicename if this field is present.
N:
N:    Refer to the systemd.unit(5) manual page for details.
N:
N:    Severity: info
N:
N:    Check: systemd
N:
I: ogon-core: systemd-service-file-missing-documentation-key lib/systemd/system/ogon-session-manager.service I: ogon-core: systemd-service-file-refers-to-var-run lib/systemd/system/ogon-rdp-server.service PIDFile /var/run/ogon-rdp-server.pid
N:
N:    The specified systemd service file declares a PIDFile= that references
N:    /var/run.
N:
N:    /var/run is now merely a symlink pointing to /run and thus it is now
N:    considered best practice that packages use /run directly.
N:
N:    Please update the specified service file.
N:
N:    Severity: info
N:
N:    Check: systemd
N:
I: ogon-core: systemd-service-file-refers-to-var-run lib/systemd/system/ogon-session-manager.service PIDFile /var/run/ogon-session-manager.pid
I: ogon source: testsuite-autopkgtest-missing
N:
N:    This package does not declare a test suite.
N:
N:    Having a test suite aids with automated quality assurance of the archive
N:    outside of your package. For example, if your package has a test suite
N:    it is possible to re-run that test suite when any of your package's
N:    dependencies have a new version and check whether that update causes
N:    problems for your package.
N:
N:    In addition, since May 2018 these tests now influence migration from
N:    unstable to testing:
N:
N:     https://lists.debian.org/debian-devel-announce/2018/05/msg00001.html
N:
N:    Please add a debian/tests/control file to your package to declare a
N:    testsuite, but please make sure to only add autopkgtests if they provide
N:    meaningful coverage of your package.
N:
N:    Refer to https://ci.debian.net/doc/ for details.
N:
N:    Severity: info
N:
N:    Check: testsuite
N:
I: ogon-core: unused-override binary-without-manpage *
N:
N:    Lintian discovered an unused override entry in its database. Most likely
N:    it was used for a false-positive that has been fixed. However, some tags
N:    are only triggered in packages built on certain architectures. In this
N:    case, the override may need an architecture qualifier.
N:
N:    Alternatively, the additional information provided by Lintian in the
N:    tag's output may changed since the override was last modified.
N:
N:    If the override is unused, please remove it from the overrides file.
N:
N:    Refer to Lintian User's Manual section 2.4.3 (Architecture specific
N:    overrides) for details.
N:
N:    Severity: info
N:
N:    Check: lintian
N:
I: ogon-core: unused-override empty-shlibs
I: libogon-backend1: wrong-section-according-to-package-name libogon-backend1 => libs
N:
N:    This package has a name suggesting that it belongs to a section other
N:    than the one it is currently categorized in.
N:
N:    Severity: info
N:
N:    Check: fields/section
N:
X: ogon source: debian-watch-does-not-check-gpg-signature

::: IGNORE this one...

N:    This watch file does not specify a means to verify the upstream tarball
N:    using a cryptographic signature.
N:
N:    If upstream distributions provides such signatures, please use the
N:    pgpsigurlmangle options in this watch file's opts= to generate the URL
N:    of an upstream GPG signature. This signature is automatically downloaded
N:    and verified against a keyring stored in debian/upstream/signing-key.asc
N:
N:    Of course, not all upstreams provide such signatures but you could
N:    request them as a way of verifying that no third party has modified the
N:    code after its release (projects such as phpmyadmin, unrealircd, and
N:    proftpd have suffered from this kind of attack).
N:
N:    Refer to the uscan(1) manual page for details.
N:
N:    Severity: pedantic
N:
N:    Check: debian/watch
N:
N:    This tag is experimental. Please file a bug report if the tag seems
N:    wrong.
N:
P: ogon source: duplicate-in-relation-field in source build-depends: libgstreamer-plugins-base1.0-dev, libgstreamer-plugins-base1.0-dev
N:
N:    The given field in the debian/control file contains relations that are
N:    either identical or imply each other. The less restrictive one can be
N:    removed. This is done automatically by dpkg-source and dpkg-gencontrol,
N:    so this does not affect the generated package.
N:
N:    Severity: pedantic
N:
N:    Check: debian/control
N:
P: ogon source: duplicate-in-relation-field in source build-depends: libssl-dev, libssl-dev P: ogon source: insecure-copyright-format-uri http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
N:
N:    Format URI of the machine-readable copyright file uses the plain HTTP
N:    unencrypted transport protocol. Using HTTPS is preferred since policy
N:    4.0.0.
N:
N:    Please use
N:    https://www.debian.org/doc/packaging-manuals/copyright-format/<version>/
N:    as the format URI instead.
N:
N:    Refer to
N:    https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ for
N:    details.
N:
N:    Severity: pedantic
N:
N:    Check: debian/copyright
N:
P: ogon source: package-lacks-versioned-build-depends-on-debhelper 10
N:
N:    The package either doesn't declare a versioned build dependency on
N:    debhelper or does not declare a versioned build dependency on a new
N:    enough version of debhelper to satisfy the declared compatibility level.
N:
N:    Recommended practice is to always declare an explicit versioned
N:    dependency on debhelper equal to or greater than the compatibility level
N:    used by the package, even if the versioned dependency isn't strictly
N:    necessary. Having a versioned dependency also helps with backports to
N:    older releases and correct builds on partially updated systems.
N:
N:    Refer to the debhelper(7) manual page for details.
N:
N:    Severity: pedantic
N:
N:    Check: debhelper
N:
P: ogon source: package-uses-old-debhelper-compat-version 10
N:
N:    This package uses a debhelper compatibility level that is no longer
N:    recommended. Please consider using a recommended level.
N:
N:    For most packages, the best way to set the compatibility level is to
N:    specify debhelper-compat (= X) as a Build-Depends in debian/control. You
N:    can also use the debian/compat file or export DH_COMPAT in debian/rules.
N:
N:    If no level is selected debhelper defaults to level 1, which is
N:    deprecated.
N:
N:    Refer to the debhelper(7) manual page for details.
N:
N:    Severity: pedantic
N:
N:    Check: debhelper
N:
P: ogon-core: renamed-tag new-package-should-close-itp-bug => initial-upload-closes-no-bugs at line 1
N:
N:    The package has an override for a tag that was renamed. Lintian tag are
N:    sometime renamed in order to improve their name.
N:
N:    Override file is dynamically translated by Lintian. Nevertheless please
N:    replace the old name by the new name.
N:
N:    Severity: pedantic
N:
N:    Check: lintian
N:
P: ogon-core: renamed-tag pkg-has-shlibs-control-file-but-no-actual-shared-libs => empty-shlibs at line 3 P: ogon-core-dbg: renamed-tag new-package-should-close-itp-bug => initial-upload-closes-no-bugs at line 1 P: ogon-dev: renamed-tag new-package-should-close-itp-bug => initial-upload-closes-no-bugs at line 1
P: ogon source: rules-requires-root-missing
N:
N:    The debian/control file is missing an explicit Rules-Requires-Root
N:    field.
N:
N:    Traditionally, Debian packages have required root privileges for some
N:    debian/rules target requiring a split between build and binary targets.
N:    This makes the builds slower due to the increased amount of invocations
N:    as well as the overhead of fakeroot itself.
N:
N:    Please specify (eg.) Rules-Requires-Root: no in the debian/control
N:    source stanza, but packagers should verify using diffoscope(1) that the
N:    binaries built with this field present are identical.
N:
N:    Refer to /usr/share/doc/dpkg-dev/rootless-builds.txt.gz, Debian Policy
N:    Manual section 4.9.2 (debian/rules and Rules-Requires-Root), and Debian
N:    Policy Manual section 5.6.31 (Rules-Requires-Root) for details.
N:
N:    Severity: pedantic
N:
N:    Check: debian/control
N:
X: ogon-core: systemd-service-file-missing-hardening-features lib/systemd/system/ogon-rdp-server.service

::: can be ignored for now.

N:    The specified systemd .service file does not appear to enable any
N:    hardening options.
N:
N:    systemd has support for many security-oriented features such as
N:    isolating services from the network, private /tmp directories, as well
N:    as control over making directories appear read-only or even
N:    inaccessible, etc.
N:
N:    Please consider supporting some options, collaborating upstream where
N:    necessary about any potential changes.
N:
N:    Refer to the systemd.service(5) manual page and
N:    http://0pointer.de/blog/projects/security.html for details.
N:
N:    Severity: pedantic
N:
N:    Check: systemd
N:
N:    This tag is experimental. Please file a bug report if the tag seems
N:    wrong.
N:
X: ogon-core: systemd-service-file-missing-hardening-features lib/systemd/system/ogon-session-manager.service

::: can be ignored for now.

X: ogon source: upstream-metadata-file-is-missing
N:
N:    This source package is not Debian-native but it does not have a
N:    debian/upstream/metadata file.
N:
N:    The Upstream MEtadata GAthered with YAml (UMEGAYA) project is an effort
N:    to collect meta-information about upstream projects from any source
N:    package. This file is in YAML format and it is used in to feed the data
N:    in the UltimateDebianDatabase. For example, it can contains the way the
N:    authors want their software be cited in publications and some
N:    bibliographic references about the software.
N:
N:    Please add a debian/upstream/metadata file.
N:
N:    Refer to https://dep-team.pages.debian.net/deps/dep12/ and
N:    https://wiki.debian.org/UpstreamMetadata for details.
N:
N:    Severity: pedantic
N:
N:    Check: debian/upstream/metadata
N:
N:    This tag is experimental. Please file a bug report if the tag seems
N:    wrong.
N:
O: ogon-core: initial-upload-closes-no-bugs
O: ogon-core-dbg: initial-upload-closes-no-bugs
O: ogon-dev: init
```
--

DAS-NETZWERKTEAM
c\o Technik- und Ökologiezentrum Eckernförde
Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde
mobile: +49 (1520) 1976 148
landline: +49 (4351) 850 8940

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

Attachment: pgpDeq1KPlfeq.pgp
Description: Digitale PGP-Signatur


Reply to: