[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

pyhoca-gui performance with wxGTK 4.0 (was: Re: Bug#947953: python3-x2go: Makes pyhoca-gui fail to start.)

Hi Yannick,

On  Do 02 Jan 2020 18:57:39 CET, Yannick Roehlly wrote:


Package: python3-x2go
Version: 0.6.1.3-1
Severity: normal
Tags: upstream

Hi,

pyhoca-gui fails to start with this error:

%<---
Traceback (most recent call last):
  File "/usr/bin/pyhoca-gui", line 50, in <module>
    app.main(args=args, logger=logger, liblogger=liblogger)
File "/usr/lib/python3/dist-packages/pyhoca/wxgui/launcher.py", line 404, in 
main
thisPyHocaGUI = PyHocaGUI(args, logger, liblogger, appname=self.PROG_NAME, 
version=self.VERSION)
File "/usr/lib/python3/dist-packages/pyhoca/wxgui/frontend.py", line 239, in 
__init__
    x2go.X2GoClient.__init__(self, **_x2goclient_kwargs)
  File "/usr/lib/python3/dist-packages/x2go/client.py", line 309, in __init__
    self.pulseaudio_installdir = os.path.normpath(pulseaudio_installdir)
  File "/usr/lib/python3.7/posixpath.py", line 340, in normpath
    path = os.fspath(path)
TypeError: expected str, bytes or os.PathLike object, not tuple
%<---

The error lies at line 308 in /usr/lib/python3/dist-packages/x2go/client.py:

%<---
        if pulseaudio_installdir == None:
            pulseaudio_installdir = os.path.join(os.getcwd(), 'pulseaudio'),
        self.pulseaudio_installdir = os.path.normpath(pulseaudio_installdir)
%<---

Removing the trailing comma makes the package work as intended.

Happy new year.

Yannick
Thanks for using pyhoca-gui from the Debian archive. Except from being the Debian maintainer of the package, I am also the upstream developer of PyHoca and Python X2Go.
After the port of PyHoca-GUI to Python3 and Py wxGTK 4.0, I noticed a performance drop down in lauched X2Go sessions. It feels like the X2Go session only refreshes 1 X11 round trip per second (maybe more round trips, but actions in the X2Go session seem to occur in 1sec intervals.
Have you also observed such a change? PyHoca-GUI uses two event loops in parallel (gevent in Python X2Go, GTK mainloop in PyHoca). With the Python2 version of PyHoca-GUI, this could be handled quite well by telling the GTK mainloop to regularly give CPU cycles to the gevent system. But in wxGTK 4.0, this seems to have changed somehow. 

Any feedback is appreciated. Thanks.

Thanks+Greets,
Mike
--

DAS-NETZWERKTEAM
c\o Technik- und Ökologiezentrum Eckernförde
Mike Gabriel, Marienthaler str. 17, 24340 Eckernförde
mobile: +49 (1520) 1976 148
landline: +49 (4351) 850 8940

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

Attachment: pgpZkZkkgkqcj.pgp
Description: Digitale PGP-Signatur

Reply to: