[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#946615: marked as done (Please make autopkgtests cross-test-friendly)

Your message dated Thu, 02 Jan 2020 14:48:01 +0000
with message-id <E1in1lZ-000GnC-8Z@fasolo.debian.org>
and subject line Bug#946615: fixed in libvncserver 0.9.12+dfsg-6
has caused the Debian Bug report #946615,
regarding Please make autopkgtests cross-test-friendly
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
946615: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=946615
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: libvncserver
Version: 0.9.12+dfsg-3
Severity: minor
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu focal ubuntu-patch

Dear maintainers,

In Ubuntu, we are in the process of moving the i386 architecture to a compatibility-only layer on amd64, and therefore we are also moving our autopkgtest infrastructure to test i386 binaries in a cross-environment.

This requires changes to some tests so that they are cross-aware and can do the right thing.

The libssh tests currently fail in this environment, because they are build tests that do not invoke the toolchain in a cross-aware manner.  I've verified that the attached patch lets the tests successfully build (and run) i386 tests on an amd64 host.

Note that upstream autopkgtest doesn't currently set DEB_HOST_ARCH so this is a complete no-op in Debian for the moment.  Support for cross-testing in autopkgtest is currently awaiting review at https://salsa.debian.org/ci-team/autopkgtest/merge_requests/69 and once landed, will still have no effect unless autopkgtest is invoked with a '-a' option.  So this change should be safe to land in your package despite this not being upstream in autopkgtest.

Thanks for considering,



diff -Nru libvncserver-0.9.12+dfsg/debian/changelog libvncserver-0.9.12+dfsg/debian/changelog
--- libvncserver-0.9.12+dfsg/debian/changelog	2019-12-11 17:25:41.000000000 +0100
+++ libvncserver-0.9.12+dfsg/debian/changelog	2019-12-11 23:26:23.000000000 +0100
@@ -1,3 +1,11 @@
+libvncserver (0.9.12+dfsg-5) unstable; urgency=medium
+
+  * debian/tests:
+    - Use the correct compiler for proposed autopkgtest cross-testing
+      support.
+
+ -- Sebastien Bacher <seb128@ubuntu.com>  Wed, 11 Dec 2019 23:26:00 +0100
+
 libvncserver (0.9.12+dfsg-4) unstable; urgency=medium
 .
   [ Antoni Villalonga ]
diff -Nru libvncserver-0.9.12+dfsg/debian/tests/smoketest-libvncclient libvncserver-0.9.12+dfsg/debian/tests/smoketest-libvncclient
--- libvncserver-0.9.12+dfsg/debian/tests/smoketest-libvncclient	2019-12-11 08:01:51.000000000 +0100
+++ libvncserver-0.9.12+dfsg/debian/tests/smoketest-libvncclient	2019-12-11 23:25:54.000000000 +0100
@@ -2,6 +2,13 @@
 set -e
 
 cd "$AUTOPKGTEST_TMP"
+
+if [ -n "${DEB_HOST_GNU_TYPE:-}" ]; then
+    CROSS_COMPILE="$DEB_HOST_GNU_TYPE-"
+else
+    CROSS_COMPILE=
+fi
+
 cat > test.c << EOF
 #include <rfb/rfbclient.h>
 
@@ -14,6 +21,6 @@
 }
 
 EOF
-gcc -Wall -o test test.c -lvncclient
+${CROSS_COMPILE}gcc -Wall -o test test.c -lvncclient
 ./test
 objdump -p test | grep "libvncclient"
diff -Nru libvncserver-0.9.12+dfsg/debian/tests/smoketest-libvncserver libvncserver-0.9.12+dfsg/debian/tests/smoketest-libvncserver
--- libvncserver-0.9.12+dfsg/debian/tests/smoketest-libvncserver	2019-12-11 08:01:51.000000000 +0100
+++ libvncserver-0.9.12+dfsg/debian/tests/smoketest-libvncserver	2019-12-11 23:25:38.000000000 +0100
@@ -2,6 +2,13 @@
 set -e
 
 cd "$AUTOPKGTEST_TMP"
+
+if [ -n "${DEB_HOST_GNU_TYPE:-}" ]; then
+    CROSS_COMPILE="$DEB_HOST_GNU_TYPE-"
+else
+    CROSS_COMPILE=
+fi
+
 cat > test.c << EOF
 #include <rfb/rfb.h>
 #include <stdio.h>
@@ -16,6 +23,6 @@
 }
 
 EOF
-gcc -Wall -o test test.c -lvncserver
+${CROSS_COMPILE}gcc -Wall -o test test.c -lvncserver
 ./test
 objdump -p test | grep "libvncserver"

--- End Message ---
--- Begin Message --- 
Source: libvncserver
Source-Version: 0.9.12+dfsg-6

We believe that the bug you reported is fixed in the latest version of
libvncserver, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 946615@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mike Gabriel <sunweaver@debian.org> (supplier of updated libvncserver package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 02 Jan 2020 15:04:42 +0100
Source: libvncserver
Architecture: source
Version: 0.9.12+dfsg-6
Distribution: unstable
Urgency: medium
Maintainer: Debian Remote Maintainers <debian-remote@lists.debian.org>
Changed-By: Mike Gabriel <sunweaver@debian.org>
Closes: 946615 947808
Changes:
 libvncserver (0.9.12+dfsg-6) unstable; urgency=medium
 .
   [ Sebastien Bacher ]
   * debian/tests:
     + Use the correct compiler for proposed autopkgtest cross-testing support.
       (Closes: #946615).
 .
   [ Mike Gabriel ]
   * debian/patches:
     + Add 0002_fix-crash-because-of-unaligned-accesses-in-hybiReadAndDecode.patch.
       Fix FTBFS on sparc64 architecture. (Closes: #947808).
Checksums-Sha1:
 06330dfd0c87182e4ec4a74aa2adbc55bf74e0cc 2326 libvncserver_0.9.12+dfsg-6.dsc
 d1b90ea5f5eb9cce7cbd949d48871b99489943b0 16044 libvncserver_0.9.12+dfsg-6.debian.tar.xz
 d7c2c8820dbf7b8ffb78513f2b39ad3bdfa6d062 8034 libvncserver_0.9.12+dfsg-6_source.buildinfo
Checksums-Sha256:
 ddb5511985eaf9277d985b81d2c5be8c14b02b0df57179698a52388992a6d32a 2326 libvncserver_0.9.12+dfsg-6.dsc
 5eac2f27777720ebeafa300ac065be44bc218fe1290741e150462c4f5accba8d 16044 libvncserver_0.9.12+dfsg-6.debian.tar.xz
 8f9b0c0fef21c961f89b441ff01201a1925ddc50362e95d2ac8fd1291b192965 8034 libvncserver_0.9.12+dfsg-6_source.buildinfo
Files:
 7f4e48160052232785a87f5e41ab2d00 2326 libs optional libvncserver_0.9.12+dfsg-6.dsc
 0d3667428dcd23510826d62ab626d133 16044 libs optional libvncserver_0.9.12+dfsg-6.debian.tar.xz
 a475d8094d3ffa2c8d646fe170a85d88 8034 libs optional libvncserver_0.9.12+dfsg-6_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJJBAEBCAAzFiEEm/uu6GwKpf+/IgeCmvRrMCV3GzEFAl4N+LoVHHN1bndlYXZl
ckBkZWJpYW4ub3JnAAoJEJr0azAldxsxAm4QALfBL4SzVg9/MpwkhgetzHV4pH0G
tkCxyAKEq338vJHPN1F2Z9FwHWjnyHOp1zrR3672EgcytxCIuROxWMMyuEfJqmLR
jw7H9cTue2NxOlLeSH+FpE8DQFy00xzUdaAnbqYw+PGAk5j1EhZevDOct/4Hzs6L
aceL5M33xyWuTMraDzmvQEX9nd2AxV6lvCZHoIqdR5ilAnT1/FT/tOqoCiUswjmv
7Ik1HNlnna16s+ElQE0bJ6ziq7uo+WSw652d1x4JrYgYqcwzpeckV4ybRHuS3sle
TupwPBXc5weKOaEUIGAaXigHjaZdWzDsA502tm3CyVIEgqXOdhFMOaEpKA1ElaPL
G3VKxzd/sJeAppf96FQpoxycTVQhtP/SqxfsfjMUNhqoUZRvJ0QyvgeEdCeCPO4q
famb9KQHkarVGK7FSUITkGF5s2DU9yldZz7m3WhJp4rF3x2Ag+lhBtnDqmbY5kBC
db1FmF2CNJy/WOSarlTCoJ3xUuEqw4cb5qLURUwrhyU3eOvjM/OUY2H/rHY/HPTL
DLchCsEW44A7wBprSzBYHJAwOBfR8YvwbTispxqz2+Hkld/G8HZKTO9SHj5m8XJ4
zlJAr0qMXMAhuD4jda71cCosaJhfnazcYHw+lLEk10jIrZs2u9RRzd1ZlDNQPEjz
ISGFbJJ2a4zauAgt
=aG/m
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: