Bug#947683: x2gothinclient-minidesktop: diversion removal misses '--rename'

[Mike Gabriel <mike.gabriel@das-netzwerkteam.de>]

Hi Andreas,

On  So 29 Dez 2019 03:59:07 CET, Andreas Beckmann wrote:

> Package: x2gothinclient-minidesktop
> Version: 1.5.0.1-1
> Severity: serious
> User: debian-qa@lists.debian.org
> Usertags: piuparts
>
> Hi,
>
> during a test with piuparts I noticed your package modifies files from
> another package in /usr. This is so wrong, I'm not even bothered to look
> up the part of policy this violates ;-P
>
> > From the attached log (scroll to the bottom...):
>
> 4m16.9s INFO: Warning: Package purging left files on system:
>   /etc/systemd/system/display-manager.service ->  
> /lib/systemd/system/lightdm.service     not owned
>   /etc/systemd/user/     owned by: systemd
>   /usr/lib/x2go/         owned by: x2gothinclient-common
>   /usr/lib/x2go/x2goclient       not owned
>   /usr/share/applications/x2goclient.desktop.disabled-by-x2gotce      
>     not owned
>   /usr/share/doc/perl-base/      owned by: perl-base
>   /usr/share/fonts/opentype/     owned by: fonts-cantarell
>   /usr/share/fonts/opentype/cantarell/   owned by: fonts-cantarell
>   /var/lib/systemd/deb-systemd-user-helper-masked/       not owned
>
> 4m16.9s ERROR: FAIL: After purging files have disappeared:
>   /usr/bin/x2goclient    owned by: x2gothinclient-minidesktop, x2goclient
>   /usr/lib/x86_64-linux-gnu/gio/         owned by:  
> glib-networking:amd64, gvfs:amd64, dconf-gsettings-backend:amd64
>   /usr/lib/x86_64-linux-gnu/gio/modules/         owned by:  
> glib-networking:amd64, gvfs:amd64, dconf-gsettings-backend:amd64
>   /usr/share/applications/x2goclient.desktop     owned by: x2goclient
>
> 4m17.0s ERROR: FAIL: Installation and purging test.
>
> The diversions are created with --rename, so the files are moved aside,
> but diversion removal lacks --rename, and the files are not restored.
>
>
> cheers,
>
> Andreas

Thanks for reporting this!

As x2gothinclient is a meta wrapper for x2goclient (and closely tied  
to it) and used on machines in a thin client environment, I went down  
the "fiddle with files in /usr of another package" path.

My question about this bug report now is: do you see your bug report  
fixed after I have added the --rename option to dpkg-divert? Or is the  
bug more about policy and you are asking me to find another solution  
for what I am doing with the diversion?

Thanks+Greets,
Mike
--

DAS-NETZWERKTEAM
c\o Technik- und Ökologiezentrum Eckernförde
Mike Gabriel, Marienthaler str. 17, 24340 Eckernförde
mobile: +49 (1520) 1976 148
landline: +49 (4351) 850 8940

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

Attachment: pgpVFlFkt53hU.pgp
Description: Digitale PGP-Signatur