[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#929499: marked as done (Crash in XKeycodeToKeysym())

Your message dated Fri, 24 May 2019 20:41:32 +0000
with message-id <E1hUH0O-0003yq-3i@fasolo.debian.org>
and subject line Bug#929499: fixed in nx-libs 2:3.5.99.19-3
has caused the Debian Bug report #929499,
regarding Crash in XKeycodeToKeysym()
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
929499: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=929499
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: src:nx-libs
Version: 2:3.5.99.19-2
Severity: important
Tags: patch fixed-upstream
Forwarded: https://github.com/ArcticaProject/nx-libs/issues/801
In libnx-x11, it was found that pointers (dpy, xkb) are referenced without them being checked for being NULL or valid object pointers. 

This was fixed by this upstream PR:
https://github.com/ArcticaProject/nx-libs/pull/809

Mike
--

DAS-NETZWERKTEAM
c\o Technik- und Ökologiezentrum Eckernförde
Mike Gabriel, Marienthaler str. 17, 24340 Eckernförde
mobile: +49 (1520) 1976 148
landline: +49 (4354) 8390 139

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de


>From 20353e96a390a029f7b3b18fc7ddd82eae98b935 Mon Sep 17 00:00:00 2001
From: Ulrich Sibiller <uli42@gmx.de>
Date: Wed, 15 May 2019 19:54:24 +0200
Subject: [PATCH 2/2] libNX_X11: add additional checks for dpy and xkb

We have seen crashes during session shutdown/connection problems
here. These patches should avoid them. There's no proper way to test
them, but they should do no harm..

Fixes ArcticaProject/nx-libs#801
Fixes https://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=695
---
 nx-X11/lib/src/xkb/XKBBind.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/nx-X11/lib/src/xkb/XKBBind.c b/nx-X11/lib/src/xkb/XKBBind.c
index 068e8f2a0..ffe5ad9d7 100644
--- a/nx-X11/lib/src/xkb/XKBBind.c
+++ b/nx-X11/lib/src/xkb/XKBBind.c
@@ -108,7 +108,21 @@ XKeycodeToKeysym(Display *dpy,
 
     _XkbCheckPendingRefresh(dpy, dpy->xkb_info);
 
+#ifdef NX_TRANS_SOCKET
+    /*
+       check again, we have seen cases where the connection broke
+       during CheckPendingEvents(), followed by a crash when accessing
+       dpy. See https://github.com/ArcticaProject/nx-libs/issues/801
+    */
+    if (_XkbUnavailable(dpy))
+        return _XKeycodeToKeysym(dpy, kc, col);
+#endif
+
     xkb = dpy->xkb_info->desc;
+#ifdef NX_TRANS_SOCKET
+    if (xkb == NULL)
+        return _XKeycodeToKeysym(dpy, kc, col);
+#endif
     if ((kc < xkb->min_key_code) || (kc > xkb->max_key_code))
         return NoSymbol;
 
-- 
2.20.1

Attachment: pgpYRX5Dnozac.pgp
Description: Digitale PGP-Signatur


--- End Message ---
--- Begin Message --- 
Source: nx-libs
Source-Version: 2:3.5.99.19-3

We believe that the bug you reported is fixed in the latest version of
nx-libs, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 929499@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mike Gabriel <sunweaver@debian.org> (supplier of updated nx-libs package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 24 May 2019 22:27:02 +0200
Source: nx-libs
Architecture: source
Version: 2:3.5.99.19-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Remote Maintainers <debian-remote@lists.debian.org>
Changed-By: Mike Gabriel <sunweaver@debian.org>
Closes: 929498 929499
Changes:
 nx-libs (2:3.5.99.19-3) unstable; urgency=medium
 .
   * debian/patches (cherry-picked from upstream):
     + Add 0003_xkbUtils.c-Catch-division-by-zero.patch.
       Catch occasional division-by-zero error. (Closes: #929498).
     + Add 0004_libNX_X11-add-additional-checks-for-dpy-and-xkb.patch.
       Don't reference dpy nor xkb if undefined. (Closes: #929499).
Checksums-Sha1:
 9e9a696ba22b176f6355d1a44e697c48f84a4bf2 3912 nx-libs_3.5.99.19-3.dsc
 31c070253cfa894a5530ded0a734a2fcfd6a9a94 53540 nx-libs_3.5.99.19-3.debian.tar.xz
 995466da3244547e46ce14583b0ecff7ca73d6d1 8452 nx-libs_3.5.99.19-3_source.buildinfo
Checksums-Sha256:
 0223a49d36984892e80e05a7fb847670e972eda31036e6f48194f1166fbbca47 3912 nx-libs_3.5.99.19-3.dsc
 84803764cba910b60831b0a78200a6eed2f74c10b48506fc6218a4ca2fdf5274 53540 nx-libs_3.5.99.19-3.debian.tar.xz
 3394e4fc13a839111ddb89e6c85bfacd09e2c7d16021d51437cf18098717214d 8452 nx-libs_3.5.99.19-3_source.buildinfo
Files:
 6c2827ca71446add07300c7afb135214 3912 x11 optional nx-libs_3.5.99.19-3.dsc
 9599fbc63da52f902fae67257ca06c36 53540 x11 optional nx-libs_3.5.99.19-3.debian.tar.xz
 e47f93fd6362991fa0271fbf80bae605 8452 x11 optional nx-libs_3.5.99.19-3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJJBAEBCAAzFiEEm/uu6GwKpf+/IgeCmvRrMCV3GzEFAlzoU/oVHHN1bndlYXZl
ckBkZWJpYW4ub3JnAAoJEJr0azAldxsxhJ0QAKl//HKOgDuV2Na2SCjSY+Moz+If
+Xyic+UxuFoWsEHzQOIOLVE5Avy0Fg7r6ffupmgODhcwrr4dREZbnnxpGRsvkg6e
Yx90Owt/HrzmtGvFHtQX7VYrG9W6Nz+uC03bkE9o/qwM/IGB8Uh4cFWi3ApX8tX1
RZqX6itDfyg0MyP1A1y5xDGVizxJWFySnL1CdxolxDyW+5eqPryDFgCp/THxYKEB
bYSHR0ftnnIS5SJ7/Go/WRZnwVkp2bGJbxr3dQfhNOhYVsu5J4B0vdTTwb92mkPF
tJBfMzKzqgGq9v+ExxbLlDK2Flf4NQlB6pUzHBj26fYs2v6cLZhqKZN8ffuI6rf+
CH9tORa8S/I1SmCNxLf8Ec1zAkS2ebxNe7JqtIJ30bR63rwnoDBKQ7jm37/nZ+jU
WpoEc8d0UcNwyY1PH8uIaQ6L7l+XOqNh2jWHE8xkGIE3VVkBMnX9XYlBUhEG1Qm7
kbYmUg8tVKaTyq3IjzjdbRyhUrDQqPCifA7XTSIZRgvrwNKObc/SbBXzYCxBnq6L
ls+jhMUMcirxyY/NWb8qYo1FGEsbDSBYzjaqX2tuP8DZVzLJDqyr0hsbY0yhJo/M
KvQkx0yb6s+X4Kf0I8eFkOT6+ZeZffRe8byk+0SgMayA702mdQPbSi8m/2Ot6Yd2
2x3cNEZPmqoocTNl
=xTy6
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: