Bug#917894: x2godesktopsharing FTCBFS: multiple reasons
Source: x2godesktopsharing
Version: 3.2.0.0-1
Tags: patch
User: helmutg@debian.org
Usertags: rebootstrap
x2godesktopsharing fails to cross build from source for multiple
reasons. For running lrelease, you must list qt5-qmake:native in
Build-Depends. The the packaging runs qmake twice: Once via
dh_auto_configure and a second time in override_dh_auto_build. While the
former picks up the host qmake, the latter uses the build qmake and thus
fails finding dependencies. Merging the calls makes x2godesktopsharing
cross buildable. Please consider applying the attached patch.
Helmut
diff --minimal -Nru x2godesktopsharing-3.2.0.0/debian/changelog x2godesktopsharing-3.2.0.0/debian/changelog
--- x2godesktopsharing-3.2.0.0/debian/changelog 2018-11-28 12:09:27.000000000 +0100
+++ x2godesktopsharing-3.2.0.0/debian/changelog 2018-12-31 13:07:24.000000000 +0100
@@ -1,3 +1,10 @@
+x2godesktopsharing (3.2.0.0-1.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix FTCBFS: (Closes: #-1)
+ + Add missing Build-Depends: qt5-qmake:native for lrelease.
+ + Run the right qmake through dh_auto_configure. Run it once only.
+
+ -- Helmut Grohne <helmut@subdivi.de> Mon, 31 Dec 2018 13:07:24 +0100
+
x2godesktopsharing (3.2.0.0-1) unstable; urgency=medium
* Initial release to Debian. (Closes: #913489).
diff --minimal -Nru x2godesktopsharing-3.2.0.0/debian/control x2godesktopsharing-3.2.0.0/debian/control
--- x2godesktopsharing-3.2.0.0/debian/control 2018-11-28 12:09:27.000000000 +0100
+++ x2godesktopsharing-3.2.0.0/debian/control 2018-12-31 13:07:23.000000000 +0100
@@ -6,6 +6,7 @@
Mike Gabriel <sunweaver@debian.org>,
Build-Depends:
debhelper-compat (= 11),
+ qt5-qmake:native,
qtbase5-dev,
qttools5-dev-tools,
libqt5svg5-dev,
diff --minimal -Nru x2godesktopsharing-3.2.0.0/debian/rules x2godesktopsharing-3.2.0.0/debian/rules
--- x2godesktopsharing-3.2.0.0/debian/rules 2018-11-28 11:53:32.000000000 +0100
+++ x2godesktopsharing-3.2.0.0/debian/rules 2018-12-31 13:07:24.000000000 +0100
@@ -20,10 +20,7 @@
override_dh_auto_configure:
lrelease x2godesktopsharing.pro
- dh_auto_configure
-
-override_dh_auto_build:
- qmake QMAKE_CFLAGS="${CPPFLAGS} ${CFLAGS}" QMAKE_CXXFLAGS="${CPPFLAGS} ${CXXFLAGS}" QMAKE_LFLAGS="${LDFLAGS}" x2godesktopsharing.pro
+ dh_auto_configure -- QMAKE_CFLAGS="${CPPFLAGS} ${CFLAGS}" QMAKE_CXXFLAGS="${CPPFLAGS} ${CXXFLAGS}" QMAKE_LFLAGS="${LDFLAGS}" x2godesktopsharing.pro
override_dh_install:
install -m 644 x2godesktopsharing $(CURDIR)/debian/x2godesktopsharing/usr/bin/
Reply to: