Bug#910239: remmina-common: External Tools not working

[Dmitri <thedrunkyardkeeper@gmail.com>]

Package: remmina-common
Version: 1.2.31.4+dfsg-1
Severity: normal

Dear Maintainer,

The external tools are not working.

dpkg-reconfigure remmina-common

dpkg -L remmina-common | grep external
/usr/share/remmina/external_tools
/usr/share/remmina/external_tools/functions.sh
/usr/share/remmina/external_tools/launcher.sh
/usr/share/remmina/external_tools/remmina_filezilla_sftp.sh
/usr/share/remmina/external_tools/remmina_filezilla_sftp_pki.sh
/usr/share/remmina/external_tools/remmina_nslookup.sh
/usr/share/remmina/external_tools/remmina_ping.sh
/usr/share/remmina/external_tools/remmina_traceroute.sh

ls  /usr/share/remmina/external_tools
functions.sh  remmina_filezilla_sftp_pki.sh  remmina_nslookup.sh
remmina_reload-gui.sh
launcher.sh   remmina_filezilla_sftp.sh      remmina_ping.sh
remmina_traceroute.sh

Steps to reproduce:
1. Select RDP connection from list
2. Ctrl+t
3. Choose any script

a. nslookup.sh
-ne
/usr/share/remmina/external_tools/remmina_nslookup.sh: 6:
/usr/share/remmina/external_tools/remmina_nslookup.sh: nslookup: not found
Hit a key to continue ...

b. ping.sh
-ne
Usage: ping [-aAbBdDfhLnOqrRUvV64] [-c count] [-i interval] [-I interface]
            [-m mark] [-M pmtudisc_option] [-l preload] [-p pattern] [-Q tos]
            [-s packetsize] [-S sndbuf] [-t ttl] [-T timestamp_option]
            [-w deadline] [-W timeout] [hop1 ...] destination
Usage: ping -6 [-aAbBdDfhLnOqrRUvV] [-c count] [-i interval] [-I interface]
             [-l preload] [-m mark] [-M pmtudisc_option]
             [-N nodeinfo_option] [-p pattern] [-Q tclass] [-s packetsize]
             [-S sndbuf] [-t ttl] [-T timestamp_option] [-w deadline]
             [-W timeout] destination
Hit a key to continue ...

c. traceroute.sh
-ne
Usage:
  traceroute [ -46dFITnreAUDV ] [ -f first_ttl ] [ -g gate,... ] [ -i device ]
[ -m max_ttl ] [ -N squeries ] [ -p port ] [ -t tos ] [ -l flow_label ] [ -w
MAX,HERE,NEAR ] [ -q nqueries ] [ -s src_addr ] [ -z sendwait ] [ --fwmark=num
] host [ packetlen ]
Options:
...


I created a new scritp in the /usr/share/remmina/external_tools

[code]
#!/bin/sh

. $(dirname $0)/functions.sh
settitle

sshpass -p PWD ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null
root@$server 'service nodm restart'

pause

[/code]

d. reload-gui.sh
-ne
ssh: Could not resolve hostname : Name or service not known
Hit a key to continue ...

Did not found information about right scripting for External Tools, there is
nothing related with "server" variable in it, only

[code]
cat /usr/share/remmina/external_tools/* | grep server
filezilla sftp://$ssh_username@$server
filezilla sftp://$ssh_username:"$ssh_password"@$server
nslookup $server
ping -c3 $server
sshpass -p PWD ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null
root@$server 'service nodm restart'
traceroute $server

[/code]

So, i bet, it is just empty one.
Is it a bug, or there is a good manual about variables in External Tools?



-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (900, 'testing'), (600, 'unstable'), (350, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.18.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8), LANGUAGE=en_GB:en
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

remmina-common depends on no packages.

Versions of packages remmina-common recommends:
ii  remmina  1.2.31.4+dfsg-1

remmina-common suggests no packages.