Control: tags -1 patch Hi, On Mon, 07 Jan 2013 15:16:42 +0100 Niels Thykier <niels@thykier.net> wrote:
Adam, Julien and I talked about this in #d-qa today and it turns out that Britney cannot reliably distinguish between RC bugs affecting source packages and RC bugs affecting binary packages.
I think the fix on the britney2 side is trivial, see below.
If a source package produces and identically named binary (e.g. src:eclipse produces a binary named eclipse), it usually doesn't matter which of them gets the "blame". The problem is when a binary has the same name as a source that _doesn't_ built it. An example in the archive being: source:sm builds binary r-cran-sm, source:screen-message builds binary sm
As bug 1078610 is currently showing, the bts seems to be the one that's confused. It doesn't export that bug at all. Once it would, it would have
"""
src:fuse 1078610
"""
in the rc_bugs_unstable and rc_bugs_testing file and all could made fine.
I'll create an MR with this (or push straight to master) after more testing.
Paul
--- a/britney2/policies/policy.py
+++ b/britney2/policies/policy.py
@@ -837,11 +837,11 @@ class RCBugPolicy(AbstractBasePolicy):
bugs_u = set()
source_name = item.package
- for src_key in (source_name, "src:%s" % source_name):
- if source_data_tdist and src_key in self._bugs_target:
- bugs_t.update(self._bugs_target[src_key])
- if src_key in self._bugs_source:
- bugs_u.update(self._bugs_source[src_key])
+ src_key=f"src:{source_name}"
+ if source_data_tdist and src_key in self._bugs_target:
+ bugs_t.update(self._bugs_target[src_key])
+ if src_key in self._bugs_source:
+ bugs_u.update(self._bugs_source[src_key])
for pkg, _, _ in source_data_srcdist.binaries:
if pkg in self._bugs_source:
Attachment:
OpenPGP_signature.asc
Description: OpenPGP digital signature