[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1118674: marked as done (trixie-pu: package lnav/0.12.4-1+deb13u1)

Your message dated Sat, 15 Nov 2025 11:21:45 +0000
with message-id <736c7150dc08501cc89945035c406eaf9688e144.camel@adam-barratt.org.uk>
and subject line Closing requests for updates included in 13.2
has caused the Debian Bug report #1118674,
regarding trixie-pu: package lnav/0.12.4-1+deb13u1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1118674: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1118674
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: trixie
X-Debbugs-Cc: lnav@packages.debian.org, Victor Seva <linuxmaniac@torreviejawireless.org>, carnil@debian.org
Control: affects -1 + src:lnav
User: release.debian.org@packages.debian.org
Usertags: pu

Hi Stable release managers,

[ Reason ]
When run inside a tmux session, lnav is not working and fails with

✘ error: unable to open TUI
 reason: unable to initialize notcurses Success
 = help: The TERM value of “tmux-256color” is not known.  Check for your terminal in https://github.com/dankamongmen/notcurses/blob/master/TERMINALS.md or use “xterm-256color”

The upstream change to address this problem is
https://github.com/tstack/lnav/commit/5e0bfa483714f05397265a690960d23ae22e1838

[ Impact ]
User cannot use lnav inside a tmux session.

[ Tests ]
A manual test of running lnav inside tmux.

[ Risks ]
Cherry-pick upstream change which is isolated to address this issue
and to handle nocurses failure to set color registers from tmux.

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in (old)stable
  [x] the issue is verified as fixed in unstable

Regards,
Salvatore

diff -Nru lnav-0.12.4/debian/changelog lnav-0.12.4/debian/changelog
--- lnav-0.12.4/debian/changelog	2025-03-23 20:37:34.000000000 +0100
+++ lnav-0.12.4/debian/changelog	2025-10-23 21:06:37.000000000 +0200
@@ -1,3 +1,9 @@
+lnav (0.12.4-1+deb13u1) trixie; urgency=medium
+
+  * [notcurses] handle failure to set cregs from tmux (Closes: #1109004)
+
+ -- Salvatore Bonaccorso <carnil@debian.org>  Thu, 23 Oct 2025 21:06:37 +0200
+
 lnav (0.12.4-1) unstable; urgency=medium
 
   * Upload to unstable
diff -Nru lnav-0.12.4/debian/patches/notcurses-handle-failure-to-set-cregs-from-tmux.patch lnav-0.12.4/debian/patches/notcurses-handle-failure-to-set-cregs-from-tmux.patch
--- lnav-0.12.4/debian/patches/notcurses-handle-failure-to-set-cregs-from-tmux.patch	1970-01-01 01:00:00.000000000 +0100
+++ lnav-0.12.4/debian/patches/notcurses-handle-failure-to-set-cregs-from-tmux.patch	2025-10-23 21:06:37.000000000 +0200
@@ -0,0 +1,45 @@
+From: Tim Stack <timothyshanestack@gmail.com>
+Date: Thu, 20 Feb 2025 20:39:49 -0800
+Subject: [notcurses] handle failure to set cregs from tmux
+Origin: https://github.com/tstack/lnav/commit/5e0bfa483714f05397265a690960d23ae22e1838
+Bug: https://github.com/tstack/lnav/issues/1390
+Bug-Debian: https://bugs.debian.org/1109004
+
+Related to #1390
+---
+ src/third-party/notcurses/src/lib/in.c | 5 +++--
+ 1 file changed, 3 insertions(+), 2 deletions(-)
+
+diff --git a/src/third-party/notcurses/src/lib/in.c b/src/third-party/notcurses/src/lib/in.c
+index ae97dd294761..f2f60f10b739 100644
+--- a/src/third-party/notcurses/src/lib/in.c
++++ b/src/third-party/notcurses/src/lib/in.c
+@@ -878,7 +878,7 @@ kitty_cb(inputctx* ictx){
+   return 2;
+ }
+ 
+-static int 
++static int
+ kitty_cb_atxtn(inputctx* ictx, int n, int with_event){
+   uint32_t txt[5]={0};
+   unsigned val = amata_next_numeric(&ictx->amata, "\x1b[", ';');
+@@ -1868,7 +1868,7 @@ build_cflow_automaton(inputctx* ictx){
+     { "[?1;2S", NULL, }, // negative cregs XTSMGRAPHICS
+     { "[?1;3S", NULL, }, // negative cregs XTSMGRAPHICS
+     { "[?1;3;S", NULL, }, // iterm2 negative cregs XTSMGRAPHICS
+-    { "[?1;3;0S", NULL, }, // negative cregs XTSMGRAPHICS
++    { "[?1;3;\\NS", NULL, }, // negative cregs XTSMGRAPHICS
+     { "[?2;1S", NULL, }, // negative pixels XTSMGRAPHICS
+     { "[?2;2S", NULL, }, // negative pixels XTSMGRAPHICS
+     { "[?2;3S", NULL, }, // negative pixels XTSMGRAPHICS
+@@ -1878,6 +1878,7 @@ build_cflow_automaton(inputctx* ictx){
+     { "[?7c", da1_cb, },   // CSI ? 7 c ("VT131")
+     { "[?1;0c", da1_cb, }, // CSI ? 1 ; 0 c ("VT101 with No Options")
+     { "[?1;2c", da1_cb, }, // CSI ? 1 ; 2 c ("VT100 with Advanced Video Option")
++    { "[?1;2;\\Dc", da1_attrs_cb, },
+     { "[?4;6c", da1_cb, }, // CSI ? 4 ; 6 c ("VT132 with Advanced Video and Graphics")
+     // CSI ? 1 2 ; Ps c ("VT125")
+     // CSI ? 6 0 ; Ps c (kmscon)
+-- 
+2.50.0
+
diff -Nru lnav-0.12.4/debian/patches/series lnav-0.12.4/debian/patches/series
--- lnav-0.12.4/debian/patches/series	2025-03-23 20:37:34.000000000 +0100
+++ lnav-0.12.4/debian/patches/series	2025-10-23 21:06:37.000000000 +0200
@@ -11,3 +11,4 @@
 disable-test_cmds.patch
 Add-loongarch64-support.patch
 disable-test_sql_indexes.patch
+notcurses-handle-failure-to-set-cregs-from-tmux.patch

--- End Message ---
--- Begin Message --- 
Package: release.debian.org
Version: 13.2

Hi,

The updates referenced in each of these bugs were included in today's
13.2 trixie point release.

Regards,

Adam

--- End Message ---
Reply to: