[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1112099: marked as done (trixie-pu: package modemmanager/1.24.0-1+deb13u1)

Your message dated Sat, 06 Sep 2025 12:14:57 +0100
with message-id <165032e5317517556dd7fd8cf24843112a3fb6ac.camel@adam-barratt.org.uk>
and subject line Closing p-u requests for fixes included in 13.1
has caused the Debian Bug report #1112099,
regarding trixie-pu: package modemmanager/1.24.0-1+deb13u1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1112099: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1112099
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: trixie
X-Debbugs-Cc: modemmanager@packages.debian.org, aferraris@debian.org
Control: affects -1 + src:modemmanager
User: release.debian.org@packages.debian.org
Usertags: pu

[ Reason ]
Fixes bug #1110197

[ Impact ]
Owners of the Fibocom FM350-GL modem (found in e.g. HP Elitebooks and Lenovo
Thinkpads) will be able to use it on Trixie; other users will be unaffected.

[ Tests ]
I manually checked no regression would occur with the hardware I have
available.
The bug reporter confirmed this update fixed their problem.

[ Risks ]
None, as the code change is trivial and has been released/tested upstream for
some time.

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in (old)stable
  [x] the issue is verified as fixed in unstable

[ Changes ]
* Backport a 2-lines patch from latest upstream release.
* Change debian/gbp.conf to target trixie.

diff -Nru modemmanager-1.24.0/debian/changelog modemmanager-1.24.0/debian/changelog
--- modemmanager-1.24.0/debian/changelog	2025-04-11 23:32:31.000000000 +0200
+++ modemmanager-1.24.0/debian/changelog	2025-08-11 10:51:27.000000000 +0200
@@ -1,3 +1,10 @@
+modemmanager (1.24.0-1+deb13u1) trixie; urgency=medium
+
+  * d/gbp.conf: target stable branch
+  * d/patches: backport upstream fix for Fibocom FM350-GL (Closes: #1110197)
+
+ -- Arnaud Ferraris <aferraris@debian.org>  Mon, 11 Aug 2025 10:51:27 +0200
+
 modemmanager (1.24.0-1) unstable; urgency=medium
 
   * New upstream release. Final release of RC already in Trixie.
diff -Nru modemmanager-1.24.0/debian/gbp.conf modemmanager-1.24.0/debian/gbp.conf
--- modemmanager-1.24.0/debian/gbp.conf	2025-04-11 23:32:31.000000000 +0200
+++ modemmanager-1.24.0/debian/gbp.conf	2025-08-11 10:51:27.000000000 +0200
@@ -1,6 +1,6 @@
 [DEFAULT]
 pristine-tar = True
-debian-branch = debian/latest
+debian-branch = debian/trixie
 upstream-branch = upstream/latest
 upstream-vcs-tag=%(version)s
 
diff -Nru modemmanager-1.24.0/debian/patches/0001-shared-fibocom-don-t-assume-parent-implements-the-fi.patch modemmanager-1.24.0/debian/patches/0001-shared-fibocom-don-t-assume-parent-implements-the-fi.patch
--- modemmanager-1.24.0/debian/patches/0001-shared-fibocom-don-t-assume-parent-implements-the-fi.patch	1970-01-01 01:00:00.000000000 +0100
+++ modemmanager-1.24.0/debian/patches/0001-shared-fibocom-don-t-assume-parent-implements-the-fi.patch	2025-08-11 10:51:27.000000000 +0200
@@ -0,0 +1,30 @@
+From: Dan Williams <dan@ioncontrol.co>
+Date: Sat, 12 Apr 2025 23:56:13 -0500
+Subject: shared-fibocom: don't assume parent implements the firmware
+ interface
+
+MMBroadbandModemMbimMtkFibocom doesn't, so don't assert it.
+
+Fixes: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/975
+
+Signed-off-by: Dan Williams <dan@ioncontrol.co>
+(cherry picked from commit 046b79a6766b6384db9cd56a9af5d148787bafe4)
+---
+ src/plugins/fibocom/mm-shared-fibocom.c | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/src/plugins/fibocom/mm-shared-fibocom.c b/src/plugins/fibocom/mm-shared-fibocom.c
+index 89be09e..0fbc9b5 100644
+--- a/src/plugins/fibocom/mm-shared-fibocom.c
++++ b/src/plugins/fibocom/mm-shared-fibocom.c
+@@ -75,8 +75,8 @@ get_private (MMSharedFibocom *self)
+         priv->class_parent = MM_SHARED_FIBOCOM_GET_IFACE (self)->peek_parent_class (self);
+ 
+         /* Setup firmware interface of parent class */
+-        g_assert (MM_SHARED_FIBOCOM_GET_IFACE (self)->peek_parent_firmware_interface);
+-        priv->iface_modem_firmware_parent = MM_SHARED_FIBOCOM_GET_IFACE (self)->peek_parent_firmware_interface (self);
++        if (MM_SHARED_FIBOCOM_GET_IFACE (self)->peek_parent_firmware_interface)
++            priv->iface_modem_firmware_parent = MM_SHARED_FIBOCOM_GET_IFACE (self)->peek_parent_firmware_interface (self);
+ 
+         g_object_set_qdata_full (G_OBJECT (self), private_quark, priv, (GDestroyNotify)private_free);
+     }
diff -Nru modemmanager-1.24.0/debian/patches/series modemmanager-1.24.0/debian/patches/series
--- modemmanager-1.24.0/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ modemmanager-1.24.0/debian/patches/series	2025-08-11 10:51:27.000000000 +0200
@@ -0,0 +1 @@
+0001-shared-fibocom-don-t-assume-parent-implements-the-fi.patch

--- End Message ---
--- Begin Message --- 
Package: release.debian.org
Version: 13.1

Hi,

Each of the updates referenced by these requests was included in
today's 13.1 point release for trixie.

Regards,

Adam

--- End Message ---
Reply to: