[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1111646: marked as done (trixie-pu: package mame/0.276+dfsg.1-1+deb13u1)

Your message dated Sat, 06 Sep 2025 12:14:57 +0100
with message-id <165032e5317517556dd7fd8cf24843112a3fb6ac.camel@adam-barratt.org.uk>
and subject line Closing p-u requests for fixes included in 13.1
has caused the Debian Bug report #1111646,
regarding trixie-pu: package mame/0.276+dfsg.1-1+deb13u1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1111646: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1111646
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: trixie
X-Debbugs-Cc: mame@packages.debian.org
Control: affects -1 + src:mame
User: release.debian.org@packages.debian.org
Usertags: pu

Hi! Please allow this update in pu, as it fixes a severe l10n
bug and the risks are minimal.

[ Reason ]

The package build system was building the translation files
during arch builds, so the generated packages were correct
in my local build using pbuilder. However, the arch-all
builder would not include them as they were not built in
arch-all buiilds.

This bug was introduced long ago and the reported bug in
the bts sadly fell through the cracks. When a duplicate
was filed, it was the final days of the trixie release
and I decided to leave the release team alone, and do this
via pu.

[ Impact ]

It's a l10n fix, MAME translations will be included in the
package again.

[ Tests ]

Manually tested locally, and the exact same fix is now live
in unstable.

[ Risks ]

Very low, no code changes involved.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]

Just add a `find` call in the binary-all target that will
msgfmt all the strings.po files and another one to cleanup
.mo files during clean.

Thanks,
Jordi

diff -Nru mame-0.276+dfsg.1/debian/changelog mame-0.276+dfsg.1/debian/changelog
--- mame-0.276+dfsg.1/debian/changelog	2025-04-06 16:23:13.000000000 +0200
+++ mame-0.276+dfsg.1/debian/changelog	2025-08-20 13:02:00.000000000 +0200
@@ -1,3 +1,11 @@
+mame (0.276+dfsg.1-1+deb13u1) trixie; urgency=medium
+
+  * Build translations explicitly in the -build-indep target.
+    Translations have been missing since the build was split
+    (closes: #1109978).
+
+ -- Jordi Mallach <jordi@debian.org>  Wed, 20 Aug 2025 13:02:00 +0200
+
 mame (0.276+dfsg.1-1) unstable; urgency=medium
 
   [ Cesare Falco ]
diff -Nru mame-0.276+dfsg.1/debian/rules mame-0.276+dfsg.1/debian/rules
--- mame-0.276+dfsg.1/debian/rules	2025-04-06 16:23:13.000000000 +0200
+++ mame-0.276+dfsg.1/debian/rules	2025-08-20 12:58:57.000000000 +0200
@@ -249,9 +249,11 @@
 
 override_dh_auto_build-indep:
 	$(MAKE) -C docs singlehtml
+	find language -mindepth 1 -type d -execdir msgfmt {}/strings.po -o {}/strings.mo \;
 
 override_dh_auto_clean:
 	PYTHON_EXECUTABLE=python3 dh_auto_clean
+	find language -name "*.mo" -delete
 
 override_dh_auto_test-arch:
 	# Run MAME's internal validation tests

--- End Message ---
--- Begin Message --- 
Package: release.debian.org
Version: 13.1

Hi,

Each of the updates referenced by these requests was included in
today's 13.1 point release for trixie.

Regards,

Adam

--- End Message ---
Reply to: