[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1111361: marked as done (trixie-pu: package auto-apt-proxy/16.8~deb13u1)

Your message dated Sat, 06 Sep 2025 12:14:57 +0100
with message-id <165032e5317517556dd7fd8cf24843112a3fb6ac.camel@adam-barratt.org.uk>
and subject line Closing p-u requests for fixes included in 13.1
has caused the Debian Bug report #1111361,
regarding trixie-pu: package auto-apt-proxy/16.8~deb13u1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1111361: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1111361
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: trixie
X-Debbugs-Cc: auto-apt-proxy@packages.debian.org
Control: affects -1 + src:auto-apt-proxy
User: release.debian.org@packages.debian.org
Usertags: pu

[ Reason ]
The auto-apt-proxy version in trixie introduces a regression for
networks where the gateway machine cannot be accessed freely. This
causes massive a slowdown when using apt with auto-apt-proxy.

auto-apt-proxy in bookworm used to only check the gateway machine as a
last resort, and try explicitly-configured proxies (e.g. via DNS) first.

This is #1108265, already fixed in testing.

[ Impact ]
apt usage with auto-apt-proxy is *very* slow.

[ Tests ]
The code passes all of its autopkgtests. The changes have also been
tested by at least one user who interacted in the bug report and
confirmed to fix the issue.

[ Risks ]
Low risk.

[ Checklist ]
  [✓] *all* changes are documented in the d/changelog
  [✓] I reviewed all changes and I approve them
  [✓] attach debdiff against the package in (old)stable
  [✓] the issue is verified as fixed in unstable

[ Changes ]
The code used to iterate on all possible IPs where a proxy might be,
including the gateway host, and only after that check DNS and mDNS. Now
it will check all local IPs, then DNS/mDNS, and only then the gateway
host.

The fix in testing is slightly different because the relevant code had
been already refactored post-trixie, but the spirit of the change is the
same.

[ Other info ]
Because I think the change is trivial and low-risk, I had alredy
uploaded it.

diff --git a/auto-apt-proxy b/auto-apt-proxy
index a38a2ac..b730234 100755
--- a/auto-apt-proxy
+++ b/auto-apt-proxy
@@ -324,9 +324,7 @@ __detect__() {
   sources="
     v4_localhost
     v4_addresses
-    v4_gateway
     v6_localhost
-    v6_gateway
     v4_explicit_proxy
     v6_explicit_proxy
     container_host
@@ -343,6 +341,19 @@ __detect__() {
   detect_DNS_SRV_record && return 0
   detect_avahi_local && return 0
 
+  sources="
+    v4_gateway
+    v6_gateway
+  "
+  for get_ips in ${sources}; do
+    for ip in $(${get_ips}); do
+      detect_apt_cacher_ng "$ip"   && return 0
+      detect_approx "$ip"          && return 0
+      detect_apt_cacher "$ip"      && return 0
+      detect_squid_deb_proxy "$ip" && return 0
+    done
+  done
+
   log_debug "no proxy detected"
   return 0
 }
diff --git a/debian/changelog b/debian/changelog
index 420cc7c..1fce970 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+auto-apt-proxy (16.8~deb13u1) trixie; urgency=medium
+
+  * Check explicitly configured proxies before network gateway
+    (Closes: #1108265)
+  * Add trixie-specific gbp.conf
+
+ -- Antonio Terceiro <terceiro@debian.org>  Sun, 10 Aug 2025 14:16:53 -0300
+
 auto-apt-proxy (16.8) unstable; urgency=medium
 
   [ Antonio Terceiro ]
diff --git a/debian/gbp.conf b/debian/gbp.conf
new file mode 100644
index 0000000..dee7f42
--- /dev/null
+++ b/debian/gbp.conf
@@ -0,0 +1,2 @@
+[DEFAULT]
+debian-branch = debian/trixie

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Package: release.debian.org
Version: 13.1

Hi,

Each of the updates referenced by these requests was included in
today's 13.1 point release for trixie.

Regards,

Adam

--- End Message ---
Reply to: