[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1109087: marked as done (bookworm-pu: package multipath-tools/0.9.4-3+deb12u2)

Your message dated Sat, 06 Sep 2025 12:14:50 +0100
with message-id <ee4c0876608d99eb3f8b333b556fbd92e7a652eb.camel@adam-barratt.org.uk>
and subject line Closing p-u requests for fixes included in 12.12
has caused the Debian Bug report #1109087,
regarding bookworm-pu: package multipath-tools/0.9.4-3+deb12u2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1109087: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1109087
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: bookworm
X-Debbugs-Cc: multipath-tools@packages.debian.org, debian-boot@lists.debian.org
Control: affects -1 + src:multipath-tools
User: release.debian.org@packages.debian.org
Usertags: pu

[ Reason ]

Upstream broke the build logic for the ANA prioritizer in a release 
just before bookworm was released. This was reported as Debian bug 
#1101332.

[ Impact ]

NVMe systems cannot use multipath-tools because the NVMe-specified 
prioritizer is missing.

[ Tests ]

Unclear. I have verified libprioana.so is now built and in the .deb.

[ Risks ]

Systems with NVMe devices will now get the ANA prioritizer as they 
should have.

I don't see any code updates to the ANA prioritizer upstream, so I 
assume it works correctly and we don't get any regressions from 
that.

Unstable has the ANA prioritizer since 13 Jun 2024, when 0.9.8 was 
imported.

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in (old)stable
  [x] the issue is verified as fixed in unstable

[ Changes ]
We apply the upstream patch that landed in 0.9.8, which flips the 
conditional in the makefile. This causes libprioana.so to be built, 
and it automatically gets picked up into multipath-tools.deb and 
multipath-tools.udeb.

[ Other info ]
multipath-tools has udebs.

diff -Nru multipath-tools-0.9.4/debian/changelog multipath-tools-0.9.4/debian/changelog
--- multipath-tools-0.9.4/debian/changelog	2023-06-24 23:07:02.000000000 +0200
+++ multipath-tools-0.9.4/debian/changelog	2025-07-11 08:03:41.000000000 +0200
@@ -1,3 +1,11 @@
+multipath-tools (0.9.4-3+deb12u2) bookworm; urgency=medium
+
+  * [571eae5] Fix Makefile to enable ANA prioritizer.
+    Apply upstream fix to correctly enable the ANA prioritizer.
+    Thanks to Lasse Bang Mikkelsen (Closes: #1101332)
+
+ -- Chris Hofstaedtler <zeha@debian.org>  Fri, 11 Jul 2025 08:03:41 +0200
+
 multipath-tools (0.9.4-3+deb12u1) bookworm; urgency=medium
 
   * [cfa5138] Re-add dm-multipath module loading to ExecStartPre
diff -Nru multipath-tools-0.9.4/debian/patches/0010-libmultipath-fix-ANA-prioritizer-enablement-logic.patch multipath-tools-0.9.4/debian/patches/0010-libmultipath-fix-ANA-prioritizer-enablement-logic.patch
--- multipath-tools-0.9.4/debian/patches/0010-libmultipath-fix-ANA-prioritizer-enablement-logic.patch	1970-01-01 01:00:00.000000000 +0100
+++ multipath-tools-0.9.4/debian/patches/0010-libmultipath-fix-ANA-prioritizer-enablement-logic.patch	2025-07-11 08:02:18.000000000 +0200
@@ -0,0 +1,27 @@
+From: Martin Wilck <mwilck@suse.com>
+Date: Thu, 4 Jan 2024 12:04:06 +0100
+Subject: libmultipath: fix ANA prioritizer enablement logic
+
+Fixes: 3e71d8a ("multipath-tools Makefiles: create config.mk")
+
+Suggested-by: Lidong Zhong <lidong.zhong@suse.com>
+Signed-off-by: Martin Wilck <mwilck@suse.com>
+Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
+Bug-Debian: #1101332
+---
+ libmultipath/prioritizers/Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/libmultipath/prioritizers/Makefile b/libmultipath/prioritizers/Makefile
+index fdec36e..ff2524c 100644
+--- a/libmultipath/prioritizers/Makefile
++++ b/libmultipath/prioritizers/Makefile
+@@ -26,7 +26,7 @@ LIBS = \
+ 	libpriopath_latency.so \
+ 	libpriosysfs.so
+ 
+-ifneq ($(ANA_SUPPORT),1)
++ifeq ($(ANA_SUPPORT),1)
+ 	LIBS += libprioana.so
+ 	CPPFLAGS += -I../nvme
+ endif
diff -Nru multipath-tools-0.9.4/debian/patches/series multipath-tools-0.9.4/debian/patches/series
--- multipath-tools-0.9.4/debian/patches/series	2023-06-24 23:07:02.000000000 +0200
+++ multipath-tools-0.9.4/debian/patches/series	2025-07-11 08:02:18.000000000 +0200
@@ -7,3 +7,4 @@
 0010-multipath.rules-do-not-assume-usrmerged-paths.patch
 0012-Reproducible-build.patch
 0006-multipathd.service-re-add-ExecStartPre.patch
+0010-libmultipath-fix-ANA-prioritizer-enablement-logic.patch

--- End Message ---
--- Begin Message --- 
Package: release.debian.org
Version: 12.12

Hi,

Each of the updates referenced by these requests was included in
today's 12.12 point release for bookworm.

Regards,

Adam

--- End Message ---
Reply to: