[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1107217: marked as done (bookworm-pu: package libfile-tail-perl/1.3-7+deb12u1)

Your message dated Sat, 06 Sep 2025 12:14:50 +0100
with message-id <ee4c0876608d99eb3f8b333b556fbd92e7a652eb.camel@adam-barratt.org.uk>
and subject line Closing p-u requests for fixes included in 12.12
has caused the Debian Bug report #1107217,
regarding bookworm-pu: package libfile-tail-perl/1.3-7+deb12u1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1107217: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1107217
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: bookworm
X-Debbugs-Cc: libfile-tail-perl@packages.debian.org, Roland Rosenfeld <roland@debian.org>, Debian Perl Group <pkg-perl-maintainers@lists.alioth.debian.org>, carnil@debian.org
Control: affects -1 + src:libfile-tail-perl
User: release.debian.org@packages.debian.org
Usertags: pu

Dear stable release managers,

[ Reason ]
There is a longstanding issue in File::Tail which under some
conditions triggers warnings

Use of uninitialized value in numeric eq (==) at /usr/share/perl5/File/Tail.pm line 391.

This is long reported upstream at
https://rt.cpan.org/Ticket/Display.html?id=109163
(with dormant upstream).

[ Impact ]
In some toolings annoying regular warnings about unitialized values in
numeric comparison.

[ Tests ]
Manual test with a real-world example triggering the problem.

[ Risks ]
While upstream is dormant, the changes were for long already applied
in Fedora for instance (not checked about others).

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in (old)stable
  [x] the issue is verified as fixed in unstable

[ Changes ]
Initialize inode to 0, as this should never happend and thus can be
initialized to it, and then later get set while probing on the real
inode.

Regards,
Salvatore

diff -Nru libfile-tail-perl-1.3/debian/changelog libfile-tail-perl-1.3/debian/changelog
--- libfile-tail-perl-1.3/debian/changelog	2022-10-14 12:55:11.000000000 +0200
+++ libfile-tail-perl-1.3/debian/changelog	2025-06-03 08:51:10.000000000 +0200
@@ -1,3 +1,12 @@
+libfile-tail-perl (1.3-7+deb12u1) bookworm; urgency=medium
+
+  * Team upload.
+
+  [ Roland Rosenfeld ]
+  * Fix uninitialized variable issue (Closes: #1104900).
+
+ -- Salvatore Bonaccorso <carnil@debian.org>  Tue, 03 Jun 2025 08:51:10 +0200
+
 libfile-tail-perl (1.3-7) unstable; urgency=medium
 
   * Update to Standards-Version 4.6.1 (no changes).
diff -Nru libfile-tail-perl-1.3/debian/patches/30_init-objects.patch libfile-tail-perl-1.3/debian/patches/30_init-objects.patch
--- libfile-tail-perl-1.3/debian/patches/30_init-objects.patch	1970-01-01 01:00:00.000000000 +0100
+++ libfile-tail-perl-1.3/debian/patches/30_init-objects.patch	2025-06-03 08:51:10.000000000 +0200
@@ -0,0 +1,33 @@
+From: Tom Callaway <spot@fedoraproject.org>
+Date: Nov 18 2020 20:29:02 +0000
+Subject: fix uninitialized variable issue (bz1283764)
+Origin: https://src.fedoraproject.org/rpms/perl-File-Tail/c/5892b1b7d2784a81debeb7cdf10e7b062533020e
+Bug: https://rt.cpan.org/Ticket/Display.html?id=109163
+Bug-Debian: https://bugs.debian.org/1104900
+Bug-Fedora: https://bugzilla.redhat.com/show_bug.cgi?id=1283764
+Last-Update: 2025-05-09
+
+--- a/Tail.pm.debug
++++ b/Tail.pm.debug
+@@ -382,6 +382,9 @@ sub reset_pointers {
+     if (defined($oldhandle)) {
+ 	# If file has not been changed since last OK read do not do anything
+ 	$st=stat($newhandle);
++	# inode 0 should never happen, so this should be safe to init to.
++	$object->{'inode'}=0 unless defined($object->{'inode'});
++	$object->{'curpos'}=0 unless defined($object->{'curpos'});
+ 	# lastread uses fractional time, stat doesn't. This can cause false
+         # negatives. 
+         # If the file was changed the same second as it was last read,
+--- a/Tail.pm
++++ b/Tail.pm
+@@ -378,6 +378,9 @@ sub reset_pointers {
+     if (defined($oldhandle)) {
+ 	# If file has not been changed since last OK read do not do anything
+ 	$st=stat($newhandle);
++	# inode 0 should never happen, so this should be safe to init to.
++	$object->{'inode'}=0 unless defined($object->{'inode'});
++	$object->{'curpos'}=0 unless defined($object->{'curpos'});
+ 	# lastread uses fractional time, stat doesn't. This can cause false
+         # negatives. 
+         # If the file was changed the same second as it was last read,
diff -Nru libfile-tail-perl-1.3/debian/patches/series libfile-tail-perl-1.3/debian/patches/series
--- libfile-tail-perl-1.3/debian/patches/series	2022-10-14 12:55:11.000000000 +0200
+++ libfile-tail-perl-1.3/debian/patches/series	2025-06-03 08:51:10.000000000 +0200
@@ -1,2 +1,3 @@
 10_pod_fixup.patch
 20_manpage_typo.patch
+30_init-objects.patch

--- End Message ---
--- Begin Message --- 
Package: release.debian.org
Version: 12.12

Hi,

Each of the updates referenced by these requests was included in
today's 12.12 point release for bookworm.

Regards,

Adam

--- End Message ---
Reply to: