[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1109789: marked as done (unblock: google-android-installers/1743526702-2)

Your message dated Thu, 14 Aug 2025 13:52:43 +0200
with message-id <906e549b-f761-4c21-b196-54e704c4bee0@debian.org>
and subject line close all open unblock requests, the trixie release happened
has caused the Debian Bug report #1109789,
regarding unblock: google-android-installers/1743526702-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1109789: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1109789
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: google-android-installers@packages.debian.org
Control: affects -1 + src:google-android-installers

Hi,

This is a pre-approval request to allow uploading and unblocking
google-android-installers/1743526702-2.

[ Reason ]
A bug was just filed 2 days ago revealing a small issue when unpacking the
downloaded zip in case the user interrupted the postinst maintainer script.
BTW there is also an update of a translation file

[ Impact ]
When there is interruption of postinst script and then the user
reinstalls/reconfigures the package, the zip might be unpacked without checking
that its sha1sum is correct.

[ Tests ]
autopkgtest install a few binary packages. All binary packages share the same
Makefile script called from the postinst script. The makefile script downloads
the zip file from google servers. Since the autopkgtests PASS,
the change doesn't have a negative impact.

[ Risks ]
No big risk according to me. The change is just moving the `sha1sum -c` command
to the parent makefile target.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

[ Other info ]
It fixes a bug which severity is set to normal. So I understand if this is not
approved. However having this change included would ensure that the downloaded
zip actually has correct sha1sum before unzipping. Until now there was a small
risk that when the user relaunches a postinst script after having interrupted
it (ie. at anytime between start of download and start of unzipping), we don't
check the sha1sum before unzipping and unzip a corrupt file.

unblock google-android-installers/1743526702-2

diff -Nru google-android-installers-1743526702/debian/Makefile google-android-installers-1743526702/debian/Makefile
--- google-android-installers-1743526702/debian/Makefile	2025-04-02 07:36:57.000000000 +0000
+++ google-android-installers-1743526702/debian/Makefile	2025-07-23 16:54:41.000000000 +0000
@@ -41,6 +41,7 @@
 	fi
 
 $(UNPACK_DIR)/source.properties: $(DL_DIR)/$(PKG_SOURCE)
+	sha1sum -c $(PKG_SOURCE).sha1
 	@echo "\n  Unzipping $(PKG_SOURCE). Please be patient, this may take some time."
 	@if [ $$(unzip -Z -1 $(DL_DIR)/$(PKG_SOURCE) | cut -d '/' -f1 | sort -u | wc -l) -gt 1 ]; then \
 	  mkdir -p ${DL_DIR}/${TRG_DIR}; \
@@ -93,7 +94,6 @@
 		  mv $(PKG_SOURCE).tmp $(PKG_SOURCE); \
 		fi" ; \
 	fi
-	sha1sum -c $(PKG_SOURCE).sha1
 
 clean:
 	-rm -rf -- $(UNPACK_DIR)
diff -Nru google-android-installers-1743526702/debian/changelog google-android-installers-1743526702/debian/changelog
--- google-android-installers-1743526702/debian/changelog	2025-04-02 07:36:57.000000000 +0000
+++ google-android-installers-1743526702/debian/changelog	2025-07-23 19:57:00.000000000 +0000
@@ -1,3 +1,10 @@
+google-android-installers (1743526702-2) unstable; urgency=medium
+
+  * Update Portuguese translation (Closes: #1107472). Thanks to Américo Monteiro
+  * move sha1sum check to $(UNPACK_DIR)/source.properties (Closes: #1109645)
+
+ -- Fab Stz <fabstz-it@yahoo.fr>  Wed, 23 Jul 2025 21:57:00 +0200
+
 google-android-installers (1743526702-1) unstable; urgency=medium
 
   * fix lintian warning extended-description-line-too-long
diff -Nru google-android-installers-1743526702/debian/google-android-build-tools-19.1.0-installer.substvars google-android-installers-1743526702/debian/google-android-build-tools-19.1.0-installer.substvars
--- google-android-installers-1743526702/debian/google-android-build-tools-19.1.0-installer.substvars	1970-01-01 00:00:00.000000000 +0000
+++ google-android-installers-1743526702/debian/google-android-build-tools-19.1.0-installer.substvars	2025-07-23 19:57:00.000000000 +0000
@@ -0,0 +1,4 @@
+build-tools:Provides=aapt (= 0~1743526702-2), aidl (= 0~1743526702-2), dexdump (= 0~1743526702-2), zipalign (= 0~1743526702-2)
+build-tools:Conflicts=aapt (>> 1), aidl (>> 1), dexdump (>> 1), zipalign (>> 1)
+build-tools:Replaces=aapt (>> 1), aidl (>> 1), dexdump (>> 1), zipalign (>> 1)
+build-tools:Ships=  - aapt,${Newline}  - aidl,${Newline}  - dexdump,${Newline}  - zipalign.
diff -Nru google-android-installers-1743526702/debian/po/pt.po google-android-installers-1743526702/debian/po/pt.po
--- google-android-installers-1743526702/debian/po/pt.po	2025-04-02 07:36:57.000000000 +0000
+++ google-android-installers-1743526702/debian/po/pt.po	2025-07-23 19:57:00.000000000 +0000
@@ -1,20 +1,24 @@
-# Portuguese translation for google-android-m2repository-installer package
-# Copyright (C) 2016 Miguel Figueiredo <elmig@debianpt.org>
-# This file is distributed under the same license as the google-android-m2repository-installer package.
-# Miguel Figueiredo <elmig@debianpt.org>, 2016
+# Translation of google-android-installers debconf messages to European Portuguese
+# Copyright (C) 2016 the google-android-installers copyright holder
+# This file is distributed under the same license as the google-android-installers package.
 #
+#
+# Miguel Figueiredo <elmig@debianpt.org>, 2016.
+# Américo Monteiro <a_monteiro@gmx.com>, 2025.
 msgid ""
 msgstr ""
-"Project-Id-Version: google-android-m2repository-installer\n"
+"Project-Id-Version: google-android-installers 1743526702-1\n"
 "Report-Msgid-Bugs-To: google-android-installers@packages.debian.org\n"
-"POT-Creation-Date: 2024-04-22 13:49+0000\n"
-"PO-Revision-Date: 2016-08-04 19:30+0100\n"
-"Last-Translator: Miguel Figueiredo <elmig@debianpt.org>\\nLanguage-Team: "
-"Portuguese <traduz@debianpt.org>\n"
+"POT-Creation-Date: 2025-02-06 09:23+0000\n"
+"PO-Revision-Date: 2025-06-07 23:50+0100\n"
+"Last-Translator: Américo Monteiro <a_monteiro@gmx.com>\n"
+"Language-Team: Portuguese <>\n"
 "Language: Portuguese\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
+"Plural-Forms: nplurals=2; plural=(n != 1);\n"
+"X-Generator: Lokalize 22.12.3\n"
 
 #. Type: select
 #. Description
@@ -36,12 +40,14 @@
 #. Description
 #: ../templates.in:2001
 msgid "URL to mirror:"
-msgstr ""
+msgstr "URL para o mirror:"
 
 #. Type: string
 #. Description
 #: ../templates.in:2001
 msgid ""
-"Set the URL to the mirror you would like to use. For example <https://dl.";
-"google.com/android/repository>."
+"Set the URL to the mirror you would like to use. For example <https://";
+"dl.google.com/android/repository>."
 msgstr ""
+"Defina o URL para o mirror que você deseja usar. Por exemplo <https://";
+"dl.google.com/android/repository>."

--- End Message ---
--- Begin Message --- 
Hi,
I'm sorry we couldn't unblock your request in time for trixie. I'm closing all open unblock requests in one go, so I'm not going into details of the particular request, but reasons are typically as follow: 
- the request came after the deadline of 2025-07-30
- the request came late and we just didn't have the time to deal with it
- the request was waiting for action from the submitter (moreinfo tag)
- the request didn't appear to be in line with the freeze policy and we
  didn't have the energy to engage (sorry for that, see our FAQ [1])
- there was discussion in the unblock request but no agreement was
  reached in time for the release.

Paul

[1] https://release.debian.org/trixie/FAQ.html

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature


--- End Message ---
Reply to: