Re: Bug#1109655: Bug#1109513: Likely golang-github-golang-protobuf-1-{3,5}-dev transition

On Mon, Jul 28, 2025 at 2:54 PM Jochen Sprickerhof <jspricke@debian.org> wrote:

* Simon Josefsson <simon@josefsson.org> [2025-07-21 10:35]:
>So are these the right patches? It seems both
>golang-github-golang-protobuf-1-3 and golang-github-golang-protobuf-1-5
>uses Conflicts and needs to be modified. The first patch below is for
>1-3 and the last one for 1-5. I have limited time so if anyone has time
>to test, revise patches and do the upload, please don't wait for me.

I did a quick test and this does not solve the upgrade problem.
To test yourself you can simply run:

PKG=golang-github-denverdino-aliyungo-dev; mmdebstrap \
--chrooted-customize-hook="set -x ; apt -y install $PKG && sed -e s/bookworm/trixie/ -i /etc/apt/sources.list && apt update" \
--chrooted-customize-hook=bash bookworm /dev/null

once it dropped into the shell edit the Packages file from outside:

unshare --map-root-user --map-auto vi \
/tmp/mmdebstrap.*/var/lib/apt/lists/deb.debian.org_debian_dists_trixie_main_binary-amd64_Packages

and then run apt dist-upgrade inside the mmdebstrap shell.

Thank you for providing an easy to use test case. I was able to run it and confirm the issue.

> I think that a Breaks+Replaces as suggested in bug #1109655 isn't
>correct. I'm not familiar enough with the details to be able to
>confidently suggest the correct solution to this problem. I did mention
>this on the debian-go mailing list hoping to solicit feedback from
>others.

Correct, the problem is at dependency resolution time where this is
unrelated. Also see above.

So, I've locally build a new package with https://salsa.debian.org/go-team/packages/golang-github-golang-protobuf-1-5/-/commit/2739999e3baf72f7e534fccc40918c8d5ce94229 included, and it seems that with your test case above, no packages are held back and the upgrade passes. My understanding is that the "Replaces" relationship give apt the hint that it is fine to remove golang-github-golang-protobuf-1-3-dev, which is the intended outcome.

In fact, all of the packages of the cloned bug no longer reference golang-github-golang-protobuf-1-3 at all. However, it is very easy to end up with a system that has golang-github-golang-protobuf-1-3-dev installed in bookworm, and we would rather have apt uninstall it for trixie ugprades in favor of golang-github-golang-protobuf-1-5.

Jochen, please let me know if I'm overlooking anything, otherwise I would upload that salsa commit tomorrow.

Thanks for looking into this.

regards,
Reinhard