Bug#1110027: unblock: polari/46.0-5
Package: release.debian.org
Severity: normal
X-Debbugs-Cc: polari@packages.debian.org, kapouer@melix.org
Control: affects -1 + src:polari
User: release.debian.org@packages.debian.org
Usertags: unblock
Please consider unblocking package polari.
[ Reason ]
Backport an upstream patch fixing ability to join a channel: #1095989
(https://gitlab.gnome.org/GNOME/polari/-/issues/232 upstream)
[ Impact ]
If not fixed, the UI becomes unresponsive when joining a channel.
[ Tests ]
I haven't tested this (I don't use this IRC client myself) but
presumably the uploader, Jérémy Lal, did. (Jérémy, please could you
follow up here with details of tests you did?)
[ Risks ]
Not a key package, but it used to be pulled in by GNOME metapackages
(before 2020) and might still be present on older installations.
The impact/visibility of the issue fixed here suggests that few developers
are using this package regularly. But the fix is simple and
narrowly-targeted (a 1-line change backported from upstream, explicitly
closing a dialog instead of trying to trigger its destructor
prematurely) so it seems low-risk; it's hard to see how it could cause a
regression worse than the issue it's fixing.
[ Checklist ]
[x] all changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in testing
unblock polari/46.0-5
diffstat for polari-46.0 polari-46.0
debian/changelog | 7 +++++++
debian/patches/319.patch | 27 +++++++++++++++++++++++++++
debian/patches/series | 1 +
src/joinDialog.js | 2 +-
4 files changed, 36 insertions(+), 1 deletion(-)
diff -Nru polari-46.0/debian/changelog polari-46.0/debian/changelog
--- polari-46.0/debian/changelog 2025-05-03 17:12:03.000000000 +0100
+++ polari-46.0/debian/changelog 2025-07-24 18:49:57.000000000 +0100
@@ -1,3 +1,10 @@
+polari (46.0-5) unstable; urgency=medium
+
+ * Team upload
+ * patch: fix crash when closing dialog. Closes: #1095989.
+
+ -- Jérémy Lal <kapouer@melix.org> Thu, 24 Jul 2025 19:49:57 +0200
+
polari (46.0-4) unstable; urgency=medium
* Team upload
diff -Nru polari-46.0/debian/patches/319.patch polari-46.0/debian/patches/319.patch
--- polari-46.0/debian/patches/319.patch 1970-01-01 01:00:00.000000000 +0100
+++ polari-46.0/debian/patches/319.patch 2025-07-24 18:49:57.000000000 +0100
@@ -0,0 +1,27 @@
+From 56544fe9c036c8a0e6f4990054730627c32bb561 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Ball=C3=B3=20Gy=C3=B6rgy?= <ballogyor@gmail.com>
+Date: Fri, 30 Aug 2024 14:12:58 +0000
+Subject: [PATCH] joinDialog: Fix closing the dialog
+
+Closes: https://gitlab.gnome.org/GNOME/polari/-/issues/232
+Part-of: <https://gitlab.gnome.org/GNOME/polari/-/merge_requests/319>
+---
+ src/joinDialog.js | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/joinDialog.js b/src/joinDialog.js
+index a667f12e..effd3510 100644
+--- a/src/joinDialog.js
++++ b/src/joinDialog.js
+@@ -154,7 +154,7 @@ class JoinDialog extends Adw.Dialog {
+ ]));
+ });
+
+- this.destroy();
++ this.close();
+ }
+
+ _onAccountsChanged() {
+--
+GitLab
+
diff -Nru polari-46.0/debian/patches/series polari-46.0/debian/patches/series
--- polari-46.0/debian/patches/series 2025-05-03 16:44:21.000000000 +0100
+++ polari-46.0/debian/patches/series 2025-07-24 18:49:57.000000000 +0100
@@ -0,0 +1 @@
+319.patch
diff -Nru polari-46.0/src/joinDialog.js polari-46.0/src/joinDialog.js
--- polari-46.0/src/joinDialog.js 2024-03-30 21:06:13.000000000 +0000
+++ polari-46.0/src/joinDialog.js 2025-07-28 10:47:55.000000000 +0100
@@ -154,7 +154,7 @@
]));
});
- this.destroy();
+ this.close();
}
_onAccountsChanged() {
Reply to: