[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1109675: marked as done (unblock: rally/4.1.0-4)



Your message dated Mon, 21 Jul 2025 22:50:06 +0000
with message-id <E1udzKg-00ARUF-0X@respighi.debian.org>
and subject line unblock rally
has caused the Debian Bug report #1109675,
regarding unblock: rally/4.1.0-4
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1109675: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1109675
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
X-Debbugs-Cc: rally@packages.debian.org, zigo@debian.org, sanvila@debian.org
Control: affects -1 + src:rally
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package rally

[ Reason ]
Fixes FTBFS Bug #1102022: Some tests do not seem to work on single-cpu systems.

[ Impact ]
Anybody trying to rebuild the package from source might find that the package
unexpectedly does not build.

[ Tests ]
I've tested that the package builds ok again on the systems where it used
to fail.

[ Risks ]
Very low. We are merely disabling some tests on cases where we have already
verified that they fail systematically and does not make sense to run them.

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

[ Other info ]
I'm actually not the maintainer but just the reporter of bug #1102022,
and I'm filing this report because I see that the maintainer has
not requested an unblock yet.

Personally, I would have disabled those tests for everybody, as timing tests
are usually prone to random failures, but I consider the change being applied
here a net improvement over the previous version, as it fixes the FTBFS bug.

unblock rally/4.1.0-4
diff --git a/debian/changelog b/debian/changelog
index 5e499e208..ac332dc00 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+rally (4.1.0-4) unstable; urgency=medium
+
+  [ Santiago Vila ]
+  * On single-CPU systems, skip tests which are known not to work
+    (Closes: #1102022).
+
+ -- Thomas Goirand <zigo@debian.org>  Fri, 04 Jul 2025 13:53:02 +0200
+
 rally (4.1.0-3) unstable; urgency=medium
 
   * Add es.po thanks to Jathan (Closes: #1092299).
diff --git a/debian/rules b/debian/rules
index 4ae400cfc..21364866d 100755
--- a/debian/rules
+++ b/debian/rules
@@ -2,6 +2,13 @@
 
 include /usr/share/openstack-pkg-tools/pkgos.make
 
+TEST_SPEC := not test_add_point_and_get_zipped_graph_2
+ifeq ($(shell nproc),1)
+  TEST_SPEC += and not test_run_scenario_constantly_for_duration
+  TEST_SPEC += and not test_run_scenario_constantly_for_duration_exception
+  TEST_SPEC += and not test_run_scenario_constantly_for_duration_timeout
+endif
+
 export TOX_ENV_NAME=debianpackage
 
 %:
@@ -29,7 +36,7 @@ ifeq (,$(findstring nocheck, $(DEB_BUILD_OPTIONS)))
 	set -e ; set -x ; for PYVER in $(PYTHON3S); do \
 		PYTHONPATH=$(CURDIR)/debian/tmp/usr/lib/python3/dist-packages \
 			PYTHON=python$$PYVER \
-			python$$PYVER -m pytest -v -n `nproc` tests/unit -Wignore -k 'not test_add_point_and_get_zipped_graph_2' ; \
+			python$$PYVER -m pytest -v -n `nproc` tests/unit -Wignore -k '$(TEST_SPEC)' ; \
 	done
 endif
 

--- End Message ---
--- Begin Message ---
Unblocked rally.

--- End Message ---

Reply to: