Bug#1108985: unblock/preapproval: redis/5:8.0.2-2
Hi Paul,
> The test fails with LOLWUT in the error message and I also
> see LOLWUT improvements mentioned in the redis diff. Is this unintended
> behavior change?
Oh, sigh. It does appear to be kinda "intended" and that command's
'Easter Egg' status meant that I paid little attention to the changes…
especially as they were made in 8.0.2 and not in 8.0.0 where one might
expect them.
Still, I think it's a bug that said output does not contain the
version number as all the previous versions of the LOLWUT output do.
To that end, I've patched [0] Redis and forwarded the change to
upstream [1].
[0] https://salsa.debian.org/lamby/pkg-redis/-/commit/aaa4dfc7442ff78fcda766faf2a184342713de9b
[1] https://github.com/redis/redis/pull/14195
I've also prepared another upload (5:8.0.2-3) that simply includes this
change (debdiff attached), and here is a Debusine run that shows the lack
of python-redis regression:
https://debusine.debian.net/debian/developers/work-request/120838/
The errors here are for gitlab and php-horde-hashtable (bad
dependencies), and proftpd-dfsg fails too, although outside of any
Redis-related tests.
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` lamby@debian.org 🍥 chris-lamb.co.uk
`-
diff --git debian/changelog debian/changelog
index 96a4fe78..b1c8d019 100644
--- debian/changelog
+++ debian/changelog
@@ -1,3 +1,11 @@
+redis (5:8.0.2-3) unstable; urgency=medium
+
+ * Add a patch to re-add "Redis ver. $REDIS_VERSION" output to the LOLWUT
+ ~Easter Egg command output as a some testsuites were relying on it
+ existing. This upstream change was made in 8.0.2, not in 8.0.0.
+
+ -- Chris Lamb <lamby@debian.org> Mon, 14 Jul 2025 09:47:32 -0700
+
redis (5:8.0.2-2) unstable; urgency=high
* CVE-2025-32023: An authenticated user may have used a specially-crafted
diff --git debian/patches/0007-Add-Redis-ver.-REDIS_VERSION-to-LOLWUT-8-output-as-a.patch debian/patches/0007-Add-Redis-ver.-REDIS_VERSION-to-LOLWUT-8-output-as-a.patch
new file mode 100644
index 00000000..1dbde061
--- /dev/null
+++ debian/patches/0007-Add-Redis-ver.-REDIS_VERSION-to-LOLWUT-8-output-as-a.patch
@@ -0,0 +1,27 @@
+From: Chris Lamb <lamby@debian.org>
+Date: Mon, 14 Jul 2025 09:37:07 -0700
+Subject: Add "Redis ver. $REDIS_VERSION" to LOLWUT 8 output as a some
+ testsuites were relying on it.
+
+eg. python-redis (https://github.com/redis/redis-py/blob/master/tests/test_commands.py#L1092)
+
+Forwarded: https://github.com/redis/redis/pull/14195
+---
+ src/lolwut8.c | 4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+diff --git a/src/lolwut8.c b/src/lolwut8.c
+index 1be150e..363a30e 100644
+--- a/src/lolwut8.c
++++ b/src/lolwut8.c
+@@ -170,7 +170,9 @@ void lolwut8Command(client *c) {
+ "\nIn 1961, Nanni Balestrini created one of the first computer-generated poems, TAPE MARK I, using an IBM 7090 mainframe. Each execution combined verses from three literary sources following algorithmic rules based on metrical compatibility and group constraints. This LOLWUT command reproduces Balestrini's original algorithm, generating new stanzas through the same computational poetry process described in Almanacco Letterario Bompiani, 1962.\n\n"
+ "https://en.wikipedia.org/wiki/Digital_poetry\n";
+ "https://www.youtube.com/watch?v=8i7uFCK7G0o (English subs)\n\n"
+- "Use: LOLWUT IT for the original Italian output.\n\n");
++ "Use: LOLWUT IT for the original Italian output. Redis ver. ");
++ combined = sdscat(combined,REDIS_VERSION);
++ combined = sdscat(combined,"\n\n");
+
+ addReplyVerbatim(c,combined,sdslen(combined),"txt");
+ sdsfree(combined);
diff --git debian/patches/series debian/patches/series
index 6ecbeef8..bbca56e3 100644
--- debian/patches/series
+++ debian/patches/series
@@ -5,3 +5,4 @@ debian-packaging/0001-Set-Debian-configuration-defaults.patch
0004-Add-support-for-USE_SYSTEM_JEMALLOC-flag.patch
0005-CVE-2025-32023.patch
0006-CVE-2025-48367.patch
+0007-Add-Redis-ver.-REDIS_VERSION-to-LOLWUT-8-output-as-a.patch
Reply to: